[PATCH] mmc: rockchip_sdhci: Do not test unsigned for being less than 0

[Kever Yang]

On 2025/7/31 19:46, Andrew Goodbody wrote:
> In rockchip_sdhci_execute_tuning the variable tuning_loop_counter is
> tested for being less than 0. Ensure that it is a signed type by
> declaring it as s8 instead of char.
>
> This issue was found by Smatch.
>
> Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>   drivers/mmc/rockchip_sdhci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c
> index 761e3619329..5e025d76a82 100644
> --- a/drivers/mmc/rockchip_sdhci.c
> +++ b/drivers/mmc/rockchip_sdhci.c
> @@ -500,7 +500,7 @@ static int rockchip_sdhci_execute_tuning(struct mmc *mmc, u8 opcode)
>   {
>   	struct rockchip_sdhc *priv = dev_get_priv(mmc->dev);
>   	struct sdhci_host *host = &priv->host;
> -	char tuning_loop_counter = SDHCI_TUNING_LOOP_COUNT;
> +	s8 tuning_loop_counter = SDHCI_TUNING_LOOP_COUNT;
>   	struct mmc_cmd cmd;
>   	u32 ctrl, blk_size;
>   	int ret;
>
> ---
> base-commit: 79f3e77133bd7248e4579827effc13f97a32a8a8
> change-id: 20250731-mmc_rockchip-78721a751131
>
> Best regards,