[PATCH v2 1/1] cmd/setexpr: support concatenation of direct strings

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Sun Feb 2 13:01:00 CET 2025


On 1/20/25 21:52, Tom Rini wrote:
> On Sun, Jan 05, 2025 at 11:46:14AM +0100, Heinrich Schuchardt wrote:
> 
>> The setexpr.s command allows to concatenate two strings.
>>
>> According to the description in doc/usage/cmd/setexpr.rst the parameters
>> value1 and value2 can be either direct values or pointers to a
>> memory location holding the values.
>>
>> Unfortunately `setexpr.s <value1> + <value2>` fails if any of the values
>> is a direct value. $? is set to false.
>>
>> * Add support for direct values in setexpr.s.
>> * Correct the unit test for "setexpr.s fred 0".
>> * Add a new unit test for "setexpr.s fred '1' + '3'" giving '13'.
>>
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> 
> This causes ut_setexpr_setexpr_test_str to fail.
> 

Hello Tom,

I am not able to reproduce this problem in Gitlab.
https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/24424

Please, provide a link to the failure.

Best regards

Heinrich


More information about the U-Boot mailing list