[PATCH] Add Kconfig option for altbootcmd when using CONFIG_BOOTCOUNT_LIMIT

[Tomáš Peterka]

Hello Tom,

sorry for the formatting of the first email. As you might have figured 
out, the it was not send using git send-email. I tried to do better 
later and I had to use different SMTP server and account 
(atheiste at seznam.cz) because our company email provider is too much 
ahead in the future.

Hope it didn't bring too much confusion and the new patch made it to 
your mailing list.

Regards,
Tomas


On 30. 01. 25 17:47, Tom Rini wrote:
> On Thu, Jan 30, 2025 at 03:44:11PM +0000, Tomáš Peterka wrote:
>
>> Hello u-boot maintainers,
>>
>> I would like to merge a simple patch for user-friendliness when configuring u-boot with Yocto. The problem is missing option for altbootcmd when using the feature CONFIG_BOOTCOUNT_LIMIT.  Simply adding the option CONFIG_BOOTCOUNT_ALTBOOTCMD into Kconfig shouldn't be a problem when there is already CONFIG_BOOTCOMMAND? Users then can use CONFIG_BOOTCOUNT_ALTBOOTCMD instead of misusing CFG_EXTRA_ENV_SETTINGS (and friends) that are usually used by configs of specific boards.
> Thanks for posting this. In general, yes, this the right approach.
>
>> Many thanks for considering this,
>> Tomas
>>
>>
>>  From 9f5d1863e99c3a33893381cc924f25797b4b6f8a Wed Jan 29 19:06:55 2025 -0600
>> From: Tomas Peterka <tomas.peterka at dronetag.com>
>> Date: Tue, 30 Jan 2025 09:00:00 +0100
>> Subject: [PATCH] Add altbootcmd to Kconfig
>> Upstream-Status: Pending
> Here is where you need to explain the purpose of the commit. Ideally
> this is what you should git send-email as well, as that might help with
> the next problem.
>
>> ---
>> diff --git a/drivers/bootcount/Kconfig b/drivers/bootcount/Kconfig
>> index 0080d2a165..982ddc9826 100644
>> --- a/drivers/bootcount/Kconfig
>> +++ b/drivers/bootcount/Kconfig
>> @@ -183,6 +183,12 @@ config BOOTCOUNT_BOOTLIMIT
>> counter being cleared.
>> If set to 0, do not set a boot limit in the environment.
>>
>> +config BOOTCOUNT_ALTBOOTCMD
>> + string "Alternative boot command when BOOTLIMIT is reached"
>> + default "env set bootfile altboot.scr; bootflow scan -lb"
>> + help
>> + Set the alternative boot command once BOOTLIMIT is reached
>> +
> I suspect due to how this was sent, there's whitespace problems.
>
> Also, we shouldn't specify a default here, as that ends up being
> per-platform. Migrating that in turn might be a bit tricky since you
> need to take it from a few different places depending on the board. It
> probably involves doing some loops of building u-boot-initial-env for
> all the platforms that enable BOOTCOUNT. If this sounds a bit too much,
> I can v2 things with that if you like.
>