[PATCH v2 0/4] FAT file renaming

[Tom Rini]

On Mon, Feb 03, 2025 at 10:24:47AM +0000, Daniel Venzin wrote:

> 
> Rework of v1 posted by Burak Gerz [1].
> 
> [1] https://lore.kernel.org/u-boot/20241212221427.GM1505244@bill-the-cat/
> 
> Changes in v2:
> - Adapt variable names for better consistency
> - Add missing rename hooks
> - Use EFI_ACCESS_DENIED for unsuccessful renames
> - Avoid using of "== 0"
> - Move the call to set_blk_dev earlier in the sequence
> - Refactor delete_dentry_long for improved reusability
> - Separate the rename implementation from changes in the filesystem layer
> - Eliminate code duplication with delete_dentry_long(..)
> - Ensure that the source file exists, but not the destination file
> - Free the fatbuf if it has been reinitialized with fat_itr_root
> - Delete orphaned FAT entry after copying file metadata

This is looking good. We just need some tests now. Ideally something
like adding test/py/tests/test_fs/test_rename.py and updating
test/py/tests/test_fs/conftest.py to have supported_fs_rename, in the
style of how symlink is handled via supported_fs_symlink and
test/py/tests/test_fs/test_symlink.py, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250203/aa1e4d7a/attachment.sig>