[PATCH] rockchip: rk3399: grf: Fix enum typos for UART2

Quentin Schulz quentin.schulz at cherry.de
Tue Feb 4 18:54:22 CET 2025


Hi Chen-Yu,

On 2/4/25 6:29 PM, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens at csie.org>
> 
> In the GRF header file, some instances of UART2 pinmux are prefixed with
> "GRF_UART2DBG" while others have "GRF_UART2DGB".
> 
> Since UART2 is the default console UART and used for debugging, it is
> more likely the name should be UART2DBG.
> 

The naming should be consistent yes, but it should match the TRM to make 
searching in it easier. UART2DGB doesn't exist in the TRM and UART2DBG* 
do and match what's here so I would vote for that to be the reason 
instead of some elaborate guessing :)

> Fix the ones that are wrong.
> 
> Fixes: a2c08df3813b ("pinctrl: add driver for rk3399")
> Fixes: fa72de10452c ("rockchip: arm64: rk3399: move grf register definitions to grf_rk3399.h")
> Signed-off-by: Chen-Yu Tsai <wens at csie.org>

Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>

Thanks!
Quentin


More information about the U-Boot mailing list