[RFC PATCH v1 00/20] Introduce support for Raspberry PI 5.

[Tom Rini]

On Thu, Feb 06, 2025 at 04:07:53PM +0000, Oleksii Moisieiev wrote:
> Hi Simon,
> 
> Please see below.
> 
> On 06/02/2025 17:58, Simon Glass wrote:
> > Hi Oleksii,
> >
> > On Thu, 6 Feb 2025 at 05:46, Oleksii Moisieiev
> > <Oleksii_Moisieiev at epam.com> wrote:
> >> Hi Simon.
> >>
> >> Please see below.
> >>
> >> -- Oleski
> >>
> >> On 06/02/2025 14:31, Simon Glass wrote:
> >>> Hi Oleksii,
> >>>
> >>> On Wed, 5 Feb 2025 at 03:15, Oleksii Moisieiev
> >>> <Oleksii_Moisieiev at epam.com> wrote:
> >>>> This patch series provides generic support for Raspberry PI 5 in
> >>>> U-Boot with additional hardware drivers.
> >>>> The following features were implemented:
> >>>> 1) add generic board config for Raspberry PI5 including device-tree
> >>>> files;
> >>>> 2) add support for RP1 chip with additional hardware;
> >>>> 3) add support for rp1-clock driver with dt-bindings update;
> >>>> 4) PCIE BRCMSTB driver support for Raspberry PI 5;
> >>>> 5) add clock/reset/gpio drivers;
> >>>> 6) add ethernet support in u-boot.
> >>>>
> >>>> This patch-series introducing the basic set of supported drivers in
> >>>> U-Boot which allows using such features as tftp and\or NFS.
> >>>> I've posted this patch series as RFC because of the following commit:
> >>>> e51ca0d221 (HACK: drivers: mfd: set bar configuration for RP1 driver, 2024-05-21)
> >>> Where is that commit?
> >> This commit is part of the patch series. Here is direct link:
> >>
> >> https://lore.kernel.org/u-boot/cover.1738749764.git.oleksii_moisieiev@epam.com/T/#m21cf23989fb08cb655e25b1a2d082632b6f865c9
> >>
> >>>> It includes HACK for rp1 driver in u-boot. This HACK is setting bar
> >>>> address in the correct order because RP1 driver in Linux Kernel rely on
> >>>> the pci BAR configuration which initializes BARs based on BAR size.
> >>>> This results the Linux set BARs in the same order on each boot.
> >>>> U-boot does initialization without any sorting so the configuration
> >>>> may be different from the Linux kernel.
> >>>> BAR address configuration is set to match the Linux Kernel order
> >>>> to avoid fails on address translation.
> >>>>
> >>>> This should be changed after upstreaming RP1 driver to the Linux kernel
> >>>> mainline.
> >>>>
> >>>> Probably somebody from Raspberry will post an advise about how this
> >>>> can be properly done.
> >>> +1
> >>>
> >>>> U-Boot support for Raspberry PI 5 was added in terms of the following
> >>>> project: https://github.com/xen-troops/meta-xt-prod-devel-rpi5
> >>>> This is xen-based dom0less system on the Raspberry PI 5 with Zephyr as
> >>>> Control Domain and Linux is Driver Domain.
> >>>>
> >>>> It is Yocto-based so it will be easy to build it on your side. Please
> >>>> visit link for the details.
> >>> I tried to apply this but I get a lot of conflicts. Can you please
> >>> advise what tree it is based on?
> >> Yocto build using the following repo:
> >>
> >> https://github.com/xen-troops/u-boot/tree/rpi5-2024.04-xt
> >>
> >> It is based on the 7-8 month old master. I didn't do any rebase on the
> >> top because
> >>
> >> it's unclear if these changes will go to upstream.
> >>
> >> So I've posted RFC before making significant changes.
> > If these add more support for rpi5 your patches would definitely be welcome.
> 
> 
> If community accepting it I will proceed with rebase to the latest
> master and post
> 
> v2. But there are still questions about "HACK" and regarding device-tree
> bindings which
> 
> still weren't upstreamed by Raspberry to the Linux kernel. So I'm asking
> the community if
> 
> dt-bindings that could be completely changed in future are acceptable at
> least for now.

So long as you're willing to update the bindings when upstream Pi
properly upstreams them, yes. Thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250206/54ca749d/attachment.sig>