[PATCH 2/6] riscv: dts: starfive: DeepComputing FML13V01 binman config

[E Shattow]

On Fri, Feb 7, 2025, 10:33 Heinrich Schuchardt <
heinrich.schuchardt at canonical.com> wrote:

>
>
> E Shattow <lucent at gmail.com> schrieb am Fr., 7. Feb. 2025, 19:12:
>
>> Is this use of filename preferable compared to a cherry-pick commit
>> of/from dt-rebasing?
>>
> The upstream device-tree is already meged into U-Boot. The entries for the
> new board matches how the other boards are implemented.
>
> I do not understand how cherry picking of patches  might be related to my
> patch series. I would not even know if you relate to commits in U-Boot or
> in Linux.
>
> Best regards
>
> Heinrich
>
>
>
>> On Fri, Feb 7, 2025, 09:22 Heinrich Schuchardt <
>> heinrich.schuchardt at canonical.com> wrote:
>>
>>> Add the DeepComputing Framework motherboard (FML13V01) to the binman
>>> include for the starfive_visionfive2_defconfig.
>>>
>>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>>> ---
>>>  arch/riscv/dts/starfive-visionfive2-binman.dtsi | 17 +++++++++++++++++
>>>  1 file changed, 17 insertions(+)
>>>
>>> diff --git a/arch/riscv/dts/starfive-visionfive2-binman.dtsi
>>> b/arch/riscv/dts/starfive-visionfive2-binman.dtsi
>>> index 4cce001e80d..63289405fbb 100644
>>> --- a/arch/riscv/dts/starfive-visionfive2-binman.dtsi
>>> +++ b/arch/riscv/dts/starfive-visionfive2-binman.dtsi
>>> @@ -16,6 +16,16 @@
>>>         itb {
>>>                 fit {
>>>                         images {
>>> +                               fdt-jh7110-deepcomputing-fml13v01 {
>>> +                                       description =
>>> "jh7110-deepcomputing-fml13v01";
>>> +                                       load = <0x40400000>;
>>> +                                       compression = "none";
>>> +
>>> +                                       blob-ext {
>>> +                                               filename =
>>> "dts/upstream/src/riscv/starfive/jh7110-deepcomputing-fml13v01.dtb";
>>> +                                       };
>>> +                               };
>>> +
>>>                                 fdt-jh7110-milkv-mars {
>>>                                         description =
>>> "jh7110-milkv-mars";
>>>                                         load = <0x40400000>;
>>> @@ -58,6 +68,13 @@
>>>                         };
>>>
>>>                         configurations {
>>> +                               conf-jh7110-deepcomputing-fml13v01 {
>>> +                                       description =
>>> "jh7110-deepcomputing-fml13v01";
>>> +                                       firmware = "opensbi";
>>> +                                       loadables = "uboot";
>>> +                                       fdt =
>>> "fdt-jh7110-deepcomputing-fml13v01";
>>> +                               };
>>> +
>>>                                 conf-jh7110-milkv-mars {
>>>                                         description =
>>> "jh7110-milkv-mars";
>>>                                         firmware = "opensbi";
>>> --
>>> 2.47.1
>>
>>
>>>

Yes you're correct disregard my comment then. I was confused for a moment
since I'm doing something else locally. Looks good! -E

Reviewed-by: E Shattow <lucent at gmail.com>