[PATCH 1/2] boot: continue in fit_find_config_node()

[Heinrich Schuchardt]

On 09.02.25 15:29, Simon Glass wrote:
> Hi Heinrich,
> 
> On Sun, 9 Feb 2025 at 04:52, Heinrich Schuchardt
> <heinrich.schuchardt at canonical.com> wrote:
>>
>> If a single configuration node lacks a description, this does not rule out
>> that another node with a description matches. Anyway we have the default
>> configuration as a fallback.
>>
>> So continue if a description is missing.
>>
> 
> That field is mandatory, so we should really fail if it is missing.
> 
> What problem are you trying to solve here?

Sure the field is needed to make a configuration selectable.

But as long as we can find a good configuration we should boot instead 
of leaving the user with a bricked device.

Best regards

Heinrich

> 
> Regards,
> Simon
> 
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>> ---
>>   boot/common_fit.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/boot/common_fit.c b/boot/common_fit.c
>> index a2f9b8d83c3..4c134e0e86f 100644
>> --- a/boot/common_fit.c
>> +++ b/boot/common_fit.c
>> @@ -57,7 +57,7 @@ int fit_find_config_node(const void *fdt)
>>                          printf("%s: Missing FDT description in DTB\n",
>>                                 __func__);
>>   #endif
>> -                       return -EINVAL;
>> +                       continue;
>>                  }
>>
>>                  if (dflt_conf_name) {
>> --
>> 2.47.1
>>
> 
> [1] https://fitspec.osfw.foundation/#configuration-nodes