[PATCH 0/3] rockchip: rk3399-gru: Fix missing TPL and SPL banner on debug UART

[Jonas Karlman]

Hi,

On 2025-02-09 17:58, Tom Rini wrote:
> On Sun, Feb 09, 2025 at 07:28:38AM -0700, Simon Glass wrote:
>> Hi Jonas,
>>
>> On Sat, 8 Feb 2025 at 15:49, Jonas Karlman <jonas at kwiboo.se> wrote:
>>>
>>> The PP1500 and PP3000 power rails must be on very early for the U-Boot
>>> TPL and SPL banner to be shown on debug UART for bob and kevin.
>>>
>>> This series restore the early power on of these power rails in
>>> board_debug_uart_init() for both TPL and SPL to restore the missing
>>> U-Boot TPL/SPL banner.
>>>
>>> The reverted patches was introduced in v2024.04-rc1.
>>>
>>> Jonas Karlman (3):
>>>   Revert "rockchip: rk3399: Drop unneeded bob and kevin board specific
>>>     code"
>>>   rockchip: rk3399-gru: Enable TPL_GPIO for bob and kevin
>>>   Revert "rockchip: rk3399: Fix TPL build of bob and kevin"
>>>
>>>  arch/arm/mach-rockchip/rk3399/rk3399.c | 23 ++++++++++++++++++++++-
>>>  configs/chromebook_bob_defconfig       |  1 +
>>>  configs/chromebook_kevin_defconfig     |  1 +
>>>  3 files changed, 24 insertions(+), 1 deletion(-)
>>>
>>> --
>>> 2.48.1
>>>
>>
>> Thanks for figuring this out! I'll let Tom run this through the labs.
> 
> You should test it when you rebase your work on top of master again.
> 

Simon did a test-run of these two reverts and the addition of TPL_GPIO
and reported the result over IRC before I posted this series.
See https://www.irccloud.com/pastebin/tYAxuilC/

  $ pe
  e99d2863179 (HEAD) rockchip: rk3399: Enable TPL_GPIO for bob and kevin
  0cf50ad5247 Revert "rockchip: rk3399: Fix TPL build of bob and kevin"
  1973a377839 Revert "rockchip: rk3399: Drop unneeded bob and kevin board specific code"
  c2e00482d00 (us/master, us/WIP/06Feb2025) Merge tag 'xilinx-for-v2025.04-rc2' of https://source.denx.de/u-boot/custodians/u-boot-microblaze
  b3c09eb3652 (us/WIP/05Feb2025, tpm/master) arm64: configs: Remove SYS_BOOTM_LEN for TI devices
  93bcabd9b24 arm: Correct dependency for STATIC_MACH_TYPE
  b16e1db2a07 armv7m: kconfig adds the NVIC option and masks the GIC option when NVIC is selected
  e335f1e3bea Merge branch 'master' of https://source.denx.de/u-boot/custodians/u-boot-sh
  0f019056b2d zynqmp: Save "bootseq" environment variable in decimal format
  eade90fd005 arm64: zynqmp: Describe images without TF-A
  $ ub-int bob
  Building U-Boot in sourcedir for chromebook_bob
  Bootstrapping U-Boot from dir /tmp/b/chromebook_bob
  Writing U-Boot using method em100
                                             
  U-Boot TPL 2025.04-rc1-00144-ge99d28631796 (Feb 07 2025 - 07:09:15)
  Channel 0: LPDDR3, 933MHz
  BW=32 Col=10 Bk=8 CS0 Row=15 CS1 Row=15 CS=2 Die BW=16 Size=2048MB
  Channel 1: LPDDR3, 933MHz
  BW=32 Col=10 Bk=8 CS0 Row=15 CS1 Row=15 CS=2 Die BW=16 Size=2048MB
  256B stride
  Trying to boot from BOOTROM
  Returning to boot ROM...
  
  U-Boot SPL 2025.04-rc1-00144-ge99d28631796 (Feb 07 2025 - 07:09:15 -0700)
  Bloblist at 100000 not found (err=-2)
  Trying to boot from SPI
  ## Checking hash(es) for config config-1 ... OK
  ## Checking hash(es) for Image atf-1 ... sha256+ OK
  ## Checking hash(es) for Image u-boot ... sha256+ OK
  ## Checking hash(es) for Image fdt-1 ... sha256+ OK

Regards,
Jonas