[PATCH v2 01/24] net: ravb: Drop empty init callback

Peter Robinson pbrobinson at gmail.com
Mon Feb 10 18:45:35 CET 2025


Marek,

In the future if you're doing a large series like this please do a cover
letter outlining what the series is trying to achieve.

Peter

On Sun, 9 Feb 2025 at 12:04, Marek Vasut <marek.vasut+renesas at mailbox.org>
wrote:

> The init function does nothing, the bb_miiphy_init() already checks
> whether the .init callback is assigned, and if not, skips calling it.
> Remove the empty init function. The entire init callback will be
> removed in follow up patches.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
> ---
> Cc: Christian Marangi <ansuelsmth at gmail.com>
> Cc: Ilias Apalodimas <ilias.apalodimas at linaro.org>
> Cc: Jerome Forissier <jerome.forissier at linaro.org>
> Cc: Jim Liu <JJLIU0 at nuvoton.com>
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Mario Six <mario.six at gdsys.cc>
> Cc: Michal Simek <michal.simek at amd.com>
> Cc: Nobuhiro Iwamatsu <iwamatsu at nigauri.org>
> Cc: Paul Barker <paul.barker.ct at bp.renesas.com>
> Cc: Ramon Fried <rfried.dev at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Sughosh Ganu <sughosh.ganu at linaro.org>
> Cc: Tom Rini <trini at konsulko.com>
> Cc: u-boot at lists.denx.de
> ---
> V2: Drop the = NULL assignment early in here.
> ---
>  drivers/net/ravb.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/net/ravb.c b/drivers/net/ravb.c
> index 7286ad19598..5df557da7da 100644
> --- a/drivers/net/ravb.c
> +++ b/drivers/net/ravb.c
> @@ -560,11 +560,6 @@ static int ravb_remove(struct udevice *dev)
>         return 0;
>  }
>
> -static int ravb_bb_init(struct bb_miiphy_bus *bus)
> -{
> -       return 0;
> -}
> -
>  static int ravb_bb_mdio_active(struct bb_miiphy_bus *bus)
>  {
>         struct ravb_priv *eth = bus->priv;
> @@ -626,7 +621,6 @@ static int ravb_bb_delay(struct bb_miiphy_bus *bus)
>  struct bb_miiphy_bus bb_miiphy_buses[] = {
>         {
>                 .name           = "ravb",
> -               .init           = ravb_bb_init,
>                 .mdio_active    = ravb_bb_mdio_active,
>                 .mdio_tristate  = ravb_bb_mdio_tristate,
>                 .set_mdio       = ravb_bb_set_mdio,
> --
> 2.47.2
>
>


More information about the U-Boot mailing list