[PATCH v2 11/35] rockchip: dts: Add an fdtmap

[Jonas Karlman]

Hi Simon,

On 2025-02-09 22:14, Simon Glass wrote:
> Add an fdtmap so it is possible to look at the image with 'binman ls'.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
> (no changes since v1)
> 
>  arch/arm/dts/rockchip-u-boot.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/dts/rockchip-u-boot.dtsi b/arch/arm/dts/rockchip-u-boot.dtsi
> index 2b01dc66056..64a6b57d5fd 100644
> --- a/arch/arm/dts/rockchip-u-boot.dtsi
> +++ b/arch/arm/dts/rockchip-u-boot.dtsi
> @@ -170,6 +170,8 @@
>  			offset = <CONFIG_SPL_PAD_TO>;
>  		};
>  #endif

Nitpick:

The Linux Devicetree Sources (DTS) Coding Style [1] recommend that each
child node is preceded with a blank line.

Please add blank line before the fdtmap node here.

[1] https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node

> +		fdtmap {
> +		};
>  	};
>  
>  #ifdef CONFIG_ROCKCHIP_SPI_IMAGE
> @@ -203,6 +205,8 @@
>  			/* Sync with u-boot,spl-payload-offset if present */
>  			offset = <CONFIG_SYS_SPI_U_BOOT_OFFS>;
>  		};

Same here.

With that fixed this is:

Reviewed-by: Jonas Karlman <jonas at kwiboo.se>

Regards,
Jonas

> +		fdtmap {
> +		};
>  	};
>  #endif /* CONFIG_ROCKCHIP_SPI_IMAGE */
>  };