[PATCH v4 05/15] lmb: notify of any changes to the LMB memory map

[Sughosh Ganu]

On Mon, 20 Jan 2025 at 15:43, Alexander Dahl <ada at thorsis.com> wrote:
>
> Hello,
>
> Am Mon, Jan 20, 2025 at 02:40:38PM +0530 schrieb Sughosh Ganu:
> > On Fri, 17 Jan 2025 at 16:40, Alexander Dahl <ada at thorsis.com> wrote:
>
> […]
>
> > > This changeset breaks build with CONFIG_CC_OPTIMIZE_FOR_DEBUG=y for
> > > me.  In a usual non-debug build, everything is fine.  However in a
> > > debug build now I get this error:
> > >
> > >       UPD     include/generated/timestamp_autogenerated.h
> > >       GEN     Makefile
> > >       Using /mnt/data/adahl/src/u-boot as source for U-Boot
> > >       CC      common/version.o
> > >       AR      common/built-in.o
> > >       LD      u-boot
> > >     arm-v5te-linux-gnueabi-ld.bfd: lib/lmb.o: in function `lmb_map_update_notify':
> > >     /mnt/data/adahl/src/u-boot/lib/lmb.c:458: undefined reference to `efi_add_memory_map_pg'
> >
> > Can you share the details of the toolchain that you are using, where
> > can I download it from. And the target that you build which shows this
> > up. Thanks.
>
> Although I'm actually building with ptxdist and
> OSELAS.Toolchain-2023.07.1/arm-v5te-linux-gnueabi for a custom board,
> you should be able to reproduce the behaviour easily with buildman on
> master when building for boards sam9x60ek or sam9x60_curiosity like
> this:
>
>     buildman -o ~/build/u-boot/buildman -e -a CC_OPTIMIZE_FOR_DEBUG sam9x60
>
> My output when running the above is this:

Sorry, I haven't spent time debugging this issue, although this is on
my todo list. Btw, since you already have a working setup, can you
please reset your tree to the following commit and then check if that
fixes your issue.

92e75ee47f1 ("board_r: Remove duplicate headers")

-sughosh

>
>     % buildman -o ~/build/u-boot/buildman -e -a CC_OPTIMIZE_FOR_DEBUG sam9x60
>     Building current source for 5 boards (5 threads, 4 jobs per thread)
>            arm:  +   sam9x60_curiosity_mmc1
>     +arm-linux-gnueabi-ld.bfd: lib/lmb.o: in function `lmb_map_update_notify':
>     +lib/lmb.c:458: undefined reference to `efi_add_memory_map_pg'
>     +make[1]: *** [Makefile:1824: u-boot] Fehler 1
>     +make: *** [Makefile:177: sub-make] Error 2
>            arm:  +   sam9x60_curiosity_mmc
>     +arm-linux-gnueabi-ld.bfd: lib/lmb.o: in function `lmb_map_update_notify':
>     +lib/lmb.c:458: undefined reference to `efi_add_memory_map_pg'
>     +make[1]: *** [Makefile:1824: u-boot] Fehler 1
>     +make: *** [Makefile:177: sub-make] Error 2
>            arm:  +   sam9x60ek_mmc
>     +arm-linux-gnueabi-ld.bfd: lib/lmb.o: in function `lmb_map_update_notify':
>     +lib/lmb.c:458: undefined reference to `efi_add_memory_map_pg'
>     +make[1]: *** [Makefile:1824: u-boot] Fehler 1
>     +make: *** [Makefile:177: sub-make] Error 2
>            arm:  +   sam9x60ek_qspiflash
>     +arm-linux-gnueabi-ld.bfd: lib/lmb.o: in function `lmb_map_update_notify':
>     +lib/lmb.c:458: undefined reference to `efi_add_memory_map_pg'
>     +make[1]: *** [Makefile:1824: u-boot] Fehler 1
>     +make: *** [Makefile:177: sub-make] Error 2
>            arm:  +   sam9x60ek_nandflash
>     +arm-linux-gnueabi-ld.bfd: lib/lmb.o: in function `lmb_map_update_notify':
>     +lib/lmb.c:458: undefined reference to `efi_add_memory_map_pg'
>     +make[1]: *** [Makefile:1824: u-boot] Fehler 1
>     +make: *** [Makefile:177: sub-make] Error 2
>         0    0    5 /5              0:00:40  : sam9x60ek_nandflash
>     Completed: 5 total built, 5 newly), duration 0:00:22, rate 0.23
>
> Greets
> Alex
>