[PATCH v3 03/29] video: Use a local mode_info struct in the EFI driver

Caleb Connolly caleb.connolly at linaro.org
Tue Feb 11 21:55:26 CET 2025



On 2/9/25 02:01, Simon Glass wrote:
> There is no need to use the global struct provided by PCI. Declare a
> local structure instead, so this can be used on ARM without including
> support for PCI ROMs.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>

This one really threw me when I first hit it :D I like this fix.

Reviewed-by: Caleb Connolly <caleb.connolly at linaro.org>

> ---
> 
> (no changes since v1)
> 
>   drivers/video/efi.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/efi.c b/drivers/video/efi.c
> index a7b6d47f9a1..94d4c93dac3 100644
> --- a/drivers/video/efi.c
> +++ b/drivers/video/efi.c
> @@ -183,6 +183,7 @@ static int efi_video_probe(struct udevice *dev)
>   {
>   	struct video_uc_plat *plat = dev_get_uclass_plat(dev);
>   	struct video_priv *uc_priv = dev_get_uclass_priv(dev);
> +	struct vesa_state mode_info;
>   	struct vesa_mode_info *vesa = &mode_info.vesa;
>   	u64 fb;
>   	int ret;

-- 
Caleb (they/them)



More information about the U-Boot mailing list