[PATCH v2 0/6] Add initial support for IPQ9574 based boards

[Caleb Connolly]

Hi Varadarajan,

On 1/30/25 05:37, Varadarajan Narayanan wrote:
> These patches introduce the initial support code needed
> for the QTI IPQ9574 SoC and RDP433 board.
> 
> 	SoC	: Qualcomm IPQ9574
> 	RAM	: 2GB DDR4
> 	Flash	: eMMC 8GB
> 	WiFi	: 1 x 2.4GHz, 1 x 5GHz, 1 x 6GHz

Thanks for respinning these, this is a lot more palatable :P

Everything looks pretty good, just a few minor changes. However the lack 
of documentation worries me a little.

I'd appreciate it if you could add a document in the next revision 
describing how to build and flash U-Boot for these platforms. You can 
look at doc/board/qualcomm/rb3gen2.rst for reference.

That document should also briefly explain what the platform is, what 
variants exist, what RDP stands for, etc.

Robert: do you have anything to add here?

Kind regards,
> 
> Thanks
> Varada
> 
> v2: Have tried to address the issues raised in v1
>      * Use the upstream kernel dts itself
>      * Dropped linker script changes
>      * Break up the patches in clock, pinctrl and defconfig subsets
>      * Dropped ipq9574 specific files and use existing mach-snapdragon
>        infrastructure itself
>      * Dropped SMEM related changes. Will have them in a separate
>        series
>      * Use reset_get_by_index instead of reset_get_by_name
> 
> v1: https://lore.kernel.org/u-boot/20240226100807.1095607-1-quic_varada@quicinc.com/
> Varadarajan Narayanan (6):
>    dts: ipq9574-rdp433-u-boot: add override dtsi
>    clk/qcom: add initial clock driver for ipq9574
>    pinctrl: qcom: Add ipq9574 pinctrl driver
>    mmc: msm_sdhci: Reset clocks before reconfiguration
>    qcom_defconfig: enable ipq9574 clock & pinctrl driver
>    configs: add ipq9574_defconfig
> 
>   arch/arm/dts/ipq9574-rdp433-u-boot.dtsi |  19 ++
>   configs/ipq9574_defconfig               | 111 ++++++++++++
>   configs/qcom_defconfig                  |   2 +
>   drivers/clk/qcom/Kconfig                |   8 +
>   drivers/clk/qcom/Makefile               |   1 +
>   drivers/clk/qcom/clock-ipq9574.c        | 100 +++++++++++
>   drivers/clk/qcom/clock-qcom.h           |   1 +
>   drivers/mmc/msm_sdhci.c                 |  10 ++
>   drivers/pinctrl/qcom/Kconfig            |   7 +
>   drivers/pinctrl/qcom/Makefile           |   1 +
>   drivers/pinctrl/qcom/pinctrl-ipq9574.c  | 226 ++++++++++++++++++++++++
>   11 files changed, 486 insertions(+)
>   create mode 100644 arch/arm/dts/ipq9574-rdp433-u-boot.dtsi
>   create mode 100644 configs/ipq9574_defconfig
>   create mode 100644 drivers/clk/qcom/clock-ipq9574.c
>   create mode 100644 drivers/pinctrl/qcom/pinctrl-ipq9574.c
> 
> 
> base-commit: a2b489b170f8382f746202c36616eaf2bc38fe86

-- 
Caleb (they/them)