[PATCH v1 5/5] ARM: tegra124: dts: mark HOST1X and DC with pre-relocation flag

[Simon Glass]

Hi Svyatoslav,

On Thu, 13 Feb 2025 at 06:53, Svyatoslav Ryhel <clamor95 at gmail.com> wrote:
>
> ср, 12 лют. 2025 р. о 13:20 Svyatoslav Ryhel <clamor95 at gmail.com> пише:
> >
> > чт, 12 груд. 2024 р. о 12:13 Svyatoslav Ryhel <clamor95 at gmail.com> пише:
> > >
> > > Same as on previous SoC generations this is required for proper
> > > video output work.
> > >
> > > Signed-off-by: Svyatoslav Ryhel <clamor95 at gmail.com>
> > > ---
> > >  arch/arm/dts/tegra124-nyan-big-u-boot.dtsi |  7 -------
> > >  arch/arm/dts/tegra124-u-boot.dtsi          | 13 +++++++++++++
> > >  2 files changed, 13 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi b/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi
> > > index 376dcdf68fb..79de06761bb 100644
> > > --- a/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi
> > > +++ b/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi
> > > @@ -7,13 +7,6 @@
> > >  #include "tegra-u-boot.dtsi"
> > >
> > >  / {
> > > -       host1x at 50000000 {
> > > -               bootph-all;
> > > -               dc at 54200000 {
> > > -                       bootph-all;
> > > -               };
> > > -       };
> > > -
> > >         spi at 7000d400 {
> > >                 spi-deactivate-delay = <500>;
> > >                 spi-max-frequency = <3000000>;
> > > diff --git a/arch/arm/dts/tegra124-u-boot.dtsi b/arch/arm/dts/tegra124-u-boot.dtsi
> > > index 7c119725528..6a02714a258 100644
> > > --- a/arch/arm/dts/tegra124-u-boot.dtsi
> > > +++ b/arch/arm/dts/tegra124-u-boot.dtsi
> > > @@ -1,3 +1,16 @@
> > >  #include <config.h>
> > >
> > >  #include "tegra-u-boot.dtsi"
> > > +
> > > +/ {
> > > +       host1x at 50000000 {
> > > +               bootph-all;
> > > +               dc at 54200000 {
> > > +                       bootph-all;
> > > +               };
> > > +
> > > +               dc at 54240000 {
> > > +                       bootph-all;
> > > +               };
> > > +       };
> > > +};
> > > --
> > > 2.43.0
> > >
> >
> > This commit for some reason breaks u-boot build for nyan-big
> > https://source.denx.de/u-boot/custodians/u-boot-tegra/-/jobs/1020521
> >
> > Video device 'dc at 54200000' cannot allocate frame buffer memory -
> > ensure the device is set up before relocation
> >
> > Indicates that bootph-all is missing though it should be present, just
> > moved into tegra124-u-boot.dtsi (this is required for any other
> > tegra124 device which would like to have video output). Isn't
> > tegra124-u-boot.dtsi applied if device specific -u-boot.dtsi is
> > defined? May anyone clarify this?

Yes it should be. You can examine the final u-boot.dtb to see what results.

In terms of the error, dc at 54240000 is disabled for Nyan_big but I'm
not sure if that is related. You could add debugging to
tegra124_lcd_bind() perhaps?

Regards,
Simon