[PATCH v1 1/1] video: bridge-uclass: add get_display_timing ops

[Simon Glass]

Hi Svyatoslav,

On Sat, 15 Feb 2025 at 10:42, Svyatoslav Ryhel <clamor95 at gmail.com> wrote:
>
> сб, 15 лют. 2025 р. о 19:24 Simon Glass <sjg at chromium.org> пише:
> >
> > Hi Svyatoslav,
> >
> > On Sat, 15 Feb 2025 at 08:52, Svyatoslav Ryhel <clamor95 at gmail.com> wrote:
> > >
> > > Add get_display_timing ops for internal bridges linked to
> > > panels that do not support EDID (MIPI-DSI panels for example)
> > > or have EDID not routed.
> > >
> > > Signed-off-by: Svyatoslav Ryhel <clamor95 at gmail.com>
> > > ---
> > >  drivers/video/bridge/video-bridge-uclass.c | 11 +++++++++++
> > >  include/video_bridge.h                     | 18 ++++++++++++++++++
> > >  2 files changed, 29 insertions(+)
> >
> > This should have a test, e.g. in test/dm/video.c or similar.
> >
>
> I totally agree, but it seems that there is no tests for
> UCLASS_VIDEO_BRIDGE unless I am missing smth. May you pls point me to
> it? Maybe I can add simple bridge analog of linux driver as sandbox
> test case?

Oh dear, that's my fault. Yes, please add something simple.

>
> > >
> > > diff --git a/drivers/video/bridge/video-bridge-uclass.c b/drivers/video/bridge/video-bridge-uclass.c
> > > index 2084a2e03ee..1b8aa12b9e8 100644
> > > --- a/drivers/video/bridge/video-bridge-uclass.c
> > > +++ b/drivers/video/bridge/video-bridge-uclass.c
> > > @@ -33,6 +33,17 @@ int video_bridge_attach(struct udevice *dev)
> > >         return ops->attach(dev);
> > >  }
> > >
> > > +int video_bridge_get_display_timing(struct udevice *dev,
> > > +                                   struct display_timing *timings)
> > > +{
> > > +       struct video_bridge_ops *ops = video_bridge_get_ops(dev);
> > > +
> > > +       if (!ops->get_display_timing)
> > > +               return -ENOSYS;
> > > +
> > > +       return ops->get_display_timing(dev, timings);
> > > +}
> > > +
> > >  int video_bridge_check_attached(struct udevice *dev)
> > >  {
> > >         struct video_bridge_priv *uc_priv = dev_get_uclass_priv(dev);
> > > diff --git a/include/video_bridge.h b/include/video_bridge.h
> > > index 3b429eac578..3860bf2cfee 100644
> > > --- a/include/video_bridge.h
> > > +++ b/include/video_bridge.h
> > > @@ -53,6 +53,16 @@ struct video_bridge_ops {
> > >          */
> > >         int (*set_backlight)(struct udevice *dev, int percent);
> > >
> > > +       /**
> > > +        * get_display_timing() - Get display timings from bridge.
> > > +        *
> > > +        * @dev:        Bridge device containing the linked display timings
> > > +        * @tim:        Place to put timings
> > > +        * @return 0 if OK, -ve on error
> > > +        */
> > > +       int (*get_display_timing)(struct udevice *dev,
> > > +                                 struct display_timing *timing);
> > > +
> > >         /**
> > >          * read_edid() - Read information from EDID
> > >          *
> > > @@ -98,6 +108,14 @@ int video_bridge_set_active(struct udevice *dev, bool active);
> > >   */
> > >  int video_bridge_check_attached(struct udevice *dev);
> > >
> > > +/**
> > > + * video_bridge_get_display_timing() - Get display timings from bridge.
> > > + *
> > > + * @dev:       Bridge device containing the linked display timings
> > > + * Return: 0 if OK, -ve on error
> > > + */
> > > +int video_bridge_get_display_timing(struct udevice *dev,
> > > +                                   struct display_timing *timing);
> > >  /**
> > >   * video_bridge_read_edid() - Read information from EDID
> > >   *
> > > --
> > > 2.43.0
> > >
> >
> > Regards,
> > Simon

Regards,
Simon