[PATCH v2 04/35] arm: Support a separate stack for VPL

[Jonas Karlman]

Hi Simon,

On 2025-02-09 22:14, Simon Glass wrote:
> VPL has the same needs as TPL in situations where the stack is at the
> top of SRAM. Add an option for this and implement it for arm
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
> Changes in v2:
> - Reply on existing CONFIG_VAL() to select the VPL stack
> - Correct reference to TPL when VPL was intended
> 
>  common/spl/Kconfig.vpl | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/common/spl/Kconfig.vpl b/common/spl/Kconfig.vpl
> index cf6b36c8e38..4abb96221bb 100644
> --- a/common/spl/Kconfig.vpl
> +++ b/common/spl/Kconfig.vpl
> @@ -266,6 +266,20 @@ config VPL_MAX_SIZE
>  	  The maximum size (in bytes) of the TPL stage. This size is determined
>  	  by the amount of internal SRAM memory.
>  
> +config VPL_HAVE_INIT_STACK

Please see my remark on the name from the TPL patch.

> +	bool "VPL requires a initial, fixed, stack-pointer location"
> +	help
> +	  Enable if the VPL phase should not use inherit its initial
> +	  stack-pointer from the settings for U-Boot proper, but should set
> +	  its own value.
> +
> +config VPL_STACK
> +	hex "Address of the initial stack-pointer for the VPL stage"
> +	depends on VPL_HAVE_INIT_STACK
> +	help
> +	  The address of the initial stack-pointer for the VPL stage.
> +	  Usually this will be the (aligned) top-of-stack.

Here you are using stage, when you changed it to phase for TPL and use
phase for the above symbol, please be consistent.

As already mentioned, please split patch 1-4 into a separate series.

Regards,
Jonas

> +
>  config VPL_BINMAN_SYMBOLS
>  	bool "Declare binman symbols in VPL"
>  	depends on VPL_FRAMEWORK && BINMAN