[PATCH v3 1/8] doc: board/qualcomm: document RDP building/flashing

[Caleb Connolly]

Hi Varadarajan,

On 2/18/25 08:54, Varadarajan Narayanan wrote:
> Introducing basic support for Qualcomm IPQxxx based RDPs.
> Document the build and flashing steps.

It looks like you forgot to squash this patch into a previous one (which 
isn't part of the series?)

> 
> Signed-off-by: Varadarajan Narayanan <quic_varada at quicinc.com>
> ---
>   doc/board/qualcomm/rdp.rst | 34 ++++++++++++++++++++--------------
>   1 file changed, 20 insertions(+), 14 deletions(-)
> 
> diff --git a/doc/board/qualcomm/rdp.rst b/doc/board/qualcomm/rdp.rst
> index b51b495e4f..f6ea689b91 100644
> --- a/doc/board/qualcomm/rdp.rst
> +++ b/doc/board/qualcomm/rdp.rst
> @@ -1,24 +1,21 @@
> -.. SPDX-License-Identifier: GPL-2.0+
> +.. SPDX-License-Identifier: GPL-2.0
>   .. sectionauthor:: Varadarajan Narayanan <quic_varada at quicinc.com>
>   
>   Qualcomm RDP
>   ============
>   
> -The Qualcomm RDPs are development boards based on the Qualcomm IPQ series of
> +Qualcomm RDPs are development boards based on the Qualcomm IPQ series of

Also, please explain what the acronym means.

>   SoCs. These SoCs are used as the application processors in WiFi router
>   platforms. RDPs come in multiple variants with differences in storage
>   medium (NOR, NAND, MMC), no. of USB and PCIe ports, n/w ports etc.
> -More information can be found on `Qualcomm's product page`_.

This should point to something like 
https://www.qualcomm.com/products/internet-of-things/networking/wi-fi-networks/networking-pro-series/qualcomm-networking-pro-820-platform

I'll give this a proper review once I have the whole file heh.

Kind regards,
> -
> -.. _Qualcomm's product page: https://www.qualcomm.com/developer/hardware/rb3-gen-2-development-kit
>   
>   Installation
>   ------------
>   First, setup ``CROSS_COMPILE`` for aarch64. Then, build U-Boot for ``IPQ9574``::
>   
> -  $ export CROSS_COMPILE=<aarch64 toolchain prefix>
> -  $ make qcom_ipq9574_mmc_defconfig
> -  $ make -j8
> +	$ export CROSS_COMPILE=<aarch64 toolchain prefix>
> +	$ make qcom_ipq9574_mmc_defconfig
> +	$ make -j8
>   
>   This will build ``u-boot.elf`` in the configured output directory.
>   
> @@ -28,20 +25,29 @@ security in this case, but it provides the firmware with some required metadata.
>   
>   To "sign" ``u-boot.elf`` you can use e.g. `qtestsign`_::
>   
> -  $ qtestsign -v6 aboot -o u-boot.mbn u-boot.elf
> +	$ qtestsign -v6 aboot -o u-boot.mbn u-boot.elf
>   
>   Then install the resulting ``u-boot.mbn`` to the ``0:APPSBL`` partition
>   on your device with::
>   
> -  => tftpboot path/to/u-boot.mbn
> -  => mmc part (and note down the start & end of '0:APPSBL' partition)
> -  => mmc erase <blk no> <count>
> -  => mmc write $fileaddr <blk no> <count>
> +	=> tftpboot path/to/u-boot.mbn
> +	=> mmc part (and note down the start & end of '0:APPSBL' partition)
> +	=> mmc erase <blk no> <count>
> +	=> mmc write $fileaddr <blk no> <count>
>   
>   U-Boot should be running after a reboot (``reset``).
>   
>   .. WARNING
> +	Boards with newer software versions would automatically go the emergency
> +	download (EDL) mode if U-Boot is not functioning as expected. If its a
> +	runtime failure at Uboot, the system will get reset (due to watchdog)
> +	and XBL will try to boot from next bank and if Bank B also doesn't have
> +	a functional image and is not booting fine, then the system will enter
> +	EDL.  A tool like bkerler's `edl`_ can be used for flashing with the
> +	firehose loader binary appropriate for the board.
> +
>   	Note that the support added is very basic. Restoring the original U-Boot
> -	without a debugger is almost impossible.
> +	on boards with older version of the software requires a debugger.
>   
>   .. _qtestsign: https://github.com/msm8916-mainline/qtestsign
> +.. _edl: https://github.com/bkerler/edl

-- 
Caleb (they/them)