[PATCH v2] env: mmc: Make redundant env in both eMMC boot partitions consider DT properties

[Tom Rini]

On Tue, Feb 11, 2025 at 02:31:08PM +0100, Marek Vasut wrote:

> Introduce a new function mmc_env_is_redundant_in_both_boot_hwparts()
> which replaces IS_ENABLED(ENV_MMC_HWPART_REDUND) and internally does
> almost the same check as the macro which assigned ENV_MMC_HWPART_REDUND
> did, and call it in place of IS_ENABLED(ENV_MMC_HWPART_REDUND).
> 
> The difference compared to IS_ENABLED(ENV_MMC_HWPART_REDUND) is
> in the last conditional, which does not do plain macro compare
> (CONFIG_ENV_OFFSET == CONFIG_ENV_OFFSET_REDUND), but instead does
> mmc_offset(mmc, 0) == mmc_offset(mmc, 1). If OF_CONTROL is not
> in use, this gets optimized back to original macro compare, but
> if OF_CONTROL is in use, this also takes into account the DT
> properties u-boot,mmc-env-offset and u-boot,mmc-env-offset-redundant.
> 
> Signed-off-by: Marek Vasut <marex at denx.de>

This introduces a failure to build on a number of platforms including
verdin-am62_a53 with:
+(verdin-am62_a53) env/mmc.c:208:13: error: 'mmc_env_is_redundant_in_both_boot_hwparts' defined but not used [-Werror=unused-function]
+(verdin-am62_a53)   208 | static bool mmc_env_is_redundant_in_both_boot_hwparts(struct mmc *mmc)
+(verdin-am62_a53)       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+(verdin-am62_a53) cc1: all warnings being treated as errors
+(verdin-am62_a53) make[3]: *** [scripts/Makefile.build:257: spl/env/mmc.o] Error 1
+(verdin-am62_a53) make[2]: *** [scripts/Makefile.xpl:550: spl/env] Error 2
+(verdin-am62_a53) make[1]: *** [Makefile:2115: spl/u-boot-spl] Error 2
+(verdin-am62_a53) make: *** [Makefile:177: sub-make] Error 2

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250218/707a7b93/attachment.sig>