[PATCH v3 8/8] configs: add qcom_ipq9574_mmc_defconfig

[Varadarajan Narayanan]

On Wed, Feb 19, 2025 at 05:48:48PM +0530, Sumit Garg wrote:
> Hi Varadarajan,
>
> On Tue, 18 Feb 2025 at 14:26, Varadarajan Narayanan
> <quic_varada at quicinc.com> wrote:
> >
> > Introduce a defconfig for the Qualcomm IPQ9574 SoC based RDPs.
> > Presently supports eMMC.
> >
> > Reviewed-by: Caleb Connolly <caleb.connolly at linaro.org>
> > Signed-off-by: Varadarajan Narayanan <quic_varada at quicinc.com>
> > ---
> > v3: Removed unnecessary comment
> > ---
> >  configs/qcom_ipq9574_mmc_defconfig | 110 +++++++++++++++++++++++++++++
> >  1 file changed, 110 insertions(+)
> >  create mode 100644 configs/qcom_ipq9574_mmc_defconfig
> >
> > diff --git a/configs/qcom_ipq9574_mmc_defconfig b/configs/qcom_ipq9574_mmc_defconfig
> > new file mode 100644
> > index 0000000000..13b47cb2b9
> > --- /dev/null
> > +++ b/configs/qcom_ipq9574_mmc_defconfig
> > @@ -0,0 +1,110 @@
> > +#include "qcom_defconfig"
> > +
> > +CONFIG_DEBUG_UART=y
> > +CONFIG_DEBUG_UART_ANNOUNCE=y
> > +CONFIG_DEBUG_UART_BASE=0x78b1000
> > +CONFIG_DEBUG_UART_MSM=y
> > +CONFIG_DEBUG_UART_CLOCK=1843200
> > +CONFIG_TEXT_BASE=0x4A240000
> > +CONFIG_REMAKE_ELF=y
> > +CONFIG_SYS_LOAD_ADDR=0x50000000
> > +CONFIG_DEFAULT_DEVICE_TREE="qcom/ipq9574-rdp433"
> > +CONFIG_FIT=y
> > +CONFIG_FIT_VERBOSE=y
> > +CONFIG_BOOTSTD_FULL=y
> > +CONFIG_BOOTDELAY=2
> > +CONFIG_OF_BOARD_SETUP=y
> > +CONFIG_SYS_CBSIZE=1024
> > +CONFIG_SYS_PBSIZE=1024
> > +CONFIG_OF_LIVE=y
> > +CONFIG_MSM_GPIO=y
> > +CONFIG_CLK_QCOM_IPQ9574=y
> > +CONFIG_PINCTRL_QCOM_IPQ9574=y
> > +CONFIG_MSM_SERIAL=y
> > +CONFIG_DM_EVENT=y
> > +CONFIG_ENV_IS_IN_MMC=y
> > +CONFIG_ENV_SIZE=0x40000
> > +CONFIG_ENV_OFFSET=0
> > +CONFIG_PARTITIONS=y
> > +CONFIG_PARTITION_UUIDS=y
> > +CONFIG_MTD=y
> > +CONFIG_MTD_PARTS=y
> > +
> > +#
> > +# Turning off many options so that u-boot size is less
> > +# than 756KB.
>
> Is this due to on-chip RAM memory constraints or flash memory layout
> that the U-Boot binary shouldn't exceed 756KB? I suppose it's rather
> better to be caught at compile time, we have something like
> SPL_MAX_SIZE but I can't find any for the main U-Boot now. So it
> should be fine to at least document it properly for now.

Flash memory layout. Based on the below feedback, will not
include qcom_defconfig and have the relevant configs alone.

> > +#
> > +# CONFIG_BOOTP_PXE is not set
> > +# CONFIG_BUTTON_KEYBOARD is not set
> > +# CONFIG_CLK_QCOM_APQ8016 is not set
> > +# CONFIG_CLK_QCOM_APQ8096 is not set
> > +# CONFIG_CLK_QCOM_QCM2290 is not set
> > +# CONFIG_CLK_QCOM_QCS404 is not set
> > +# CONFIG_CLK_QCOM_SC7280 is not set
> > +# CONFIG_CLK_QCOM_SDM845 is not set
> > +# CONFIG_CLK_QCOM_SM6115 is not set
> > +# CONFIG_CLK_QCOM_SM8150 is not set
> > +# CONFIG_CLK_QCOM_SM8250 is not set
> > +# CONFIG_CLK_QCOM_SM8550 is not set
> > +# CONFIG_CLK_QCOM_SM8650 is not set
> > +# CONFIG_CMD_BOOTP is not set
> > +# CONFIG_CMD_GPIO is not set
> > +# CONFIG_CMD_I2C is not set
> > +# CONFIG_CMD_MII is not set
> > +# CONFIG_CMD_NET is not set
> > +# CONFIG_CMD_PING is not set
> > +# CONFIG_CMD_PINMUX is not set
> > +# CONFIG_CMD_PXE is not set
> > +# CONFIG_CMD_RNG is not set
> > +# CONFIG_CMD_TFTPBOOT is not set
> > +# CONFIG_DISPLAY_CPUINFO is not set
> > +# CONFIG_DM_ETH is not set
> > +# CONFIG_DM_I2C is not set
> > +# CONFIG_DM_KEYBOARD is not set
> > +# CONFIG_DM_MDIO is not set
> > +# CONFIG_DM_PMIC is not set
> > +# CONFIG_DM_REGULATOR_COMMON is not set
> > +# CONFIG_DM_REGULATOR_FIXED is not set
> > +# CONFIG_DM_REGULATOR is not set
> > +# CONFIG_DM_REGULATOR_QCOM_RPMH is not set
> > +# CONFIG_DM_USB is not set
> > +# CONFIG_ETH is not set
> > +# CONFIG_FS_EXT4 is not set
> > +# CONFIG_FS_FAT is not set
> > +# CONFIG_I2C is not set
> > +# CONFIG_INPUT is not set
> > +# CONFIG_IOMMU is not set
> > +# CONFIG_LEGACY_CRYPTO_BASIC is not set
> > +# CONFIG_LEGACY_CRYPTO_CERT is not set
> > +# CONFIG_LEGACY_CRYPTO is not set
> > +# CONFIG_LIB_RAND is not set
> > +# CONFIG_MD5_LEGACY is not set
> > +# CONFIG_MISC is not set
> > +# CONFIG_MMC_HS200_SUPPORT is not set
> > +# CONFIG_NETDEVICES is not set
> > +# CONFIG_NVMEM is not set
> > +# CONFIG_PHY_GIGE is not set
> > +# CONFIG_PHYLIB is not set
> > +# CONFIG_PINCTRL_QCOM_APQ8016 is not set
> > +# CONFIG_PINCTRL_QCOM_APQ8096 is not set
> > +# CONFIG_PINCTRL_QCOM_IPQ4019 is not set
> > +# CONFIG_PINCTRL_QCOM_QCM2290 is not set
> > +# CONFIG_PINCTRL_QCOM_QCS404 is not set
> > +# CONFIG_PINCTRL_QCOM_SDM845 is not set
> > +# CONFIG_PINCTRL_QCOM_SM6115 is not set
> > +# CONFIG_PINCTRL_QCOM_SM8150 is not set
> > +# CONFIG_PINCTRL_QCOM_SM8250 is not set
> > +# CONFIG_PINCTRL_QCOM_SM8550 is not set
> > +# CONFIG_PINCTRL_QCOM_SM8650 is not set
> > +# CONFIG_PMIC_CHILDREN is not set
> > +# CONFIG_PMIC_QCOM is not set
> > +# CONFIG_POWER_DOMAIN is not set
> > +# CONFIG_PXE_UTILS is not set
> > +# CONFIG_QCOM_HYP_SMMU is not set
> > +# CONFIG_REGEX is not set
> > +# CONFIG_RGMII is not set
> > +# CONFIG_SHA1_LEGACY is not set
> > +# CONFIG_SHA256_LEGACY is not set
> > +# CONFIG_UFS is not set
> > +# CONFIG_USB is not set
> > +# CONFIG_VIDEO is not set
>
> We should rather create a separate defconfig for this platform. It's
> just redundant to include generic defconfig and then make it platform
> specific.

Sure. Will post a new version.

Thanks
Varada