[PATCH v4 2/7] dts: ipq9574-rdp433-u-boot: add override dtsi

Caleb Connolly caleb.connolly at linaro.org
Thu Feb 20 21:44:23 CET 2025



On 2/20/25 07:39, Varadarajan Narayanan wrote:
> Add initial support for the IPQ9574 MMC based RDP platforms.
> Define memory layout statically.
> 
> Signed-off-by: Varadarajan Narayanan <quic_varada at quicinc.com>
> ---
> v3: Fix comments and give additional details
>      No code change
> 
> v2: Use upstream and override DT instead of own DT
> ---
>   arch/arm/dts/ipq9574-rdp433-u-boot.dtsi | 25 +++++++++++++++++++++++++
>   1 file changed, 25 insertions(+)
>   create mode 100644 arch/arm/dts/ipq9574-rdp433-u-boot.dtsi
> 
> diff --git a/arch/arm/dts/ipq9574-rdp433-u-boot.dtsi b/arch/arm/dts/ipq9574-rdp433-u-boot.dtsi
> new file mode 100644
> index 0000000000..390e2338d6
> --- /dev/null
> +++ b/arch/arm/dts/ipq9574-rdp433-u-boot.dtsi
> @@ -0,0 +1,25 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2025, Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +/ {
> +	/* Will be removed when SMEM parsing is updated */
> +	memory at 40000000 {
> +		device_type = "memory";
> +		reg = <0x0 0x40000000 0x0 0x40000000>,
> +		      <0x0 0x4a500000 0x0 0x00100000>;
> +	};
> +};
> +
> +&sdhc_1 {
> +	sdhci-caps-mask = <0x0 0x04000000>;
> +	sdhci-caps = <0x0 0x04000000>;	/* SDHCI_CAN_VDD_180 */
> +
> +	/*
> +	 * This reset is needed to clear out the settings done by
> +	 * previous boot loader. Without this the SDHCI_RESET_ALL
> +	 * reset done sdhci_init() times out.
> +	 */
> +	resets = <&gcc GCC_SDCC_BCR>;

I understand that Linux doesn't need this reset, but devicetree doesn't 
exist in Linux to describe what Linux drivers need, it exists to 
describe the hardware. This reset should go upstream. Ultimately this 
file exists purely as a stop-gap solution and the goal must be to get 
rid of it in the future.

I'd appreciate it if you could also send a patch to the kernel adding 
this missing reset.

Reviewed-by: Caleb Connolly <caleb.connolly at linaro.org>
> +};

-- 
Caleb (they/them)



More information about the U-Boot mailing list