Re: 回复: [EXT] Re: [PATCH v4 05/20] scmi_protocols: add SCMI misc protocol protocol_id and message_id for getting the ROM passover data

[Marek Vasut]

On 2/21/25 10:39 AM, Alice Guo (OSS) wrote:
>> -----邮件原件-----
>> 发件人: Marek Vasut <marex at denx.de>
>> 发送时间: 2025年1月24日 21:57
>> 收件人: Alice Guo (OSS) <alice.guo at oss.nxp.com>; Tom Rini
>> <trini at konsulko.com>; Stefano Babic <sbabic at denx.de>; Fabio Estevam
>> <festevam at gmail.com>; dl-uboot-imx <uboot-imx at nxp.com>; Lukasz
>> Majewski <lukma at denx.de>; Sean Anderson <seanga2 at gmail.com>; Simon
>> Glass <sjg at chromium.org>; Alper Nebi Yasak <alpernebiyasak at gmail.com>
>> 抄送: u-boot at lists.denx.de; tharvey at gateworks.com; Alice Guo
>> <alice.guo at nxp.com>; Peng Fan <peng.fan at nxp.com>; Ye Li <ye.li at nxp.com>
>> 主题: [EXT] Re: [PATCH v4 05/20] scmi_protocols: add SCMI misc protocol
>> protocol_id and message_id for getting the ROM passover data
>>
>> Caution: This is an external email. Please take care when clicking links or
>> opening attachments. When in doubt, report the message using the 'Report this
>> email' button
>>
>>
>> On 1/15/25 2:28 PM, Alice Guo wrote:
>>> From: Peng Fan <peng.fan at nxp.com>
>>>
>>> SCMI misc protocol is intended for miscellaneous functions which are
>>> device specific and are usually defined to access bit fields. This
>>> patch adds SCMI misc protocol protocol_id and message_id for getting
>>> the ROM passover data.
>> Is this iMX specific or is this generic protocol ?
>>
>> If generic , then the symbol SCMI_PROTOCOL_ID_IMX_MISC should not contain
>> _IMX substring .
> 
> SCMI_PROTOCOL_ID_IMX_MISC is IMX specific protocol.

It would be good to explicitly spell this out in the commit message , 
that this is some non-generic vendor-specific extension.