[PATCH v2 2/5] samsung: snow: Use BLOBLIST_FIXED

[Tom Rini]

On Wed, Feb 26, 2025 at 09:26:15AM -0700, Simon Glass wrote:

> Snow requires a fixed bloblist to operate, so re-enable this option.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Fixes: 864106f3c47 ("bloblist: Make BLOBLIST_ALLOC the default")
> ---
> 
> (no changes since v1)
> 
>  configs/snow_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/configs/snow_defconfig b/configs/snow_defconfig
> index 7a1dc80b1cc..f9fd76daa67 100644
> --- a/configs/snow_defconfig
> +++ b/configs/snow_defconfig
> @@ -33,7 +33,9 @@ CONFIG_DISTRO_DEFAULTS=y
>  CONFIG_SYS_PBSIZE=1024
>  CONFIG_SILENT_CONSOLE=y
>  CONFIG_BLOBLIST=y
> +CONFIG_BLOBLIST_FIXED=y
>  # CONFIG_SPL_BLOBLIST is not set
> +CONFIG_BLOBLIST_ADDR=0x43d00000
>  # CONFIG_SPL_FRAMEWORK is not set
>  CONFIG_SPL_FOOTPRINT_LIMIT=y
>  CONFIG_SPL_MAX_FOOTPRINT=0x3800

I'm not going to NAK the patch, but:
- "snow" does not require a bloblist to operate, just to run the
  bloblist tests on hardware as implied by d985f1dbddb2 ("bootstd: Add a
  test for the bootstd menu"), which also don't seem to run anyhow?
- We could just as easily continue to use an allocated bloblist if
  CONFIG_SYS_MALLOC_F_LEN is increased to say 0x800 from 0x400 (which is
  the same size as the requested bloblist allocation).
- This very tiny SYS_MALLOC_F_LEN is just the old default value from
  when it was bumped up to 0x2000 for most platforms and is also safe
  from a quick test.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250226/3b9096d0/attachment.sig>