[PATCH 1/1] cmd: simplify eficonfig_init()

Ilias Apalodimas ilias.apalodimas at linaro.org
Thu Feb 27 15:56:54 CET 2025


Hi Heinrich,

[...]

> @@ -2287,22 +2287,8 @@ static efi_status_t eficonfig_init(void)
>         unsigned long columns, rows;
>
>         if (!init) {
> -               ret = efi_search_protocol(efi_root, &efi_guid_text_input_protocol, &handler);
> -               if (ret != EFI_SUCCESS)
> -                       return ret;
> -
> -               ret = efi_protocol_open(handler, (void **)&cin, efi_root, NULL,
> -                                       EFI_OPEN_PROTOCOL_GET_PROTOCOL);
> -               if (ret != EFI_SUCCESS)
> -                       return ret;
> -               ret = efi_search_protocol(efi_root, &efi_guid_text_output_protocol, &handler);
> -               if (ret != EFI_SUCCESS)
> -                       return ret;
> -
> -               ret = efi_protocol_open(handler, (void **)&cout, efi_root, NULL,

[...]

You need to remove the definition of handler as well.

Other than that, looks good

Cheers
/Ilias


More information about the U-Boot mailing list