[resend v3 17/19] drivers: mtd: nand: Enabled Kconfig and Makefile for SPL_NAND_FRAMEWORK

[Maniyam, Dinesh]

> -----Original Message-----
> From: Michael Nazzareno Trimarchi <michael at amarulasolutions.com>
> Sent: Friday, 28 February 2025 5:30 am
> To: Maniyam, Dinesh <dinesh.maniyam at intel.com>
> Cc: u-boot at lists.denx.de; Marek <marex at denx.de>; Simon
> <simon.k.r.goldschmidt at gmail.com>; Tom Rini <trini at konsulko.com>; Dario
> Binacchi <dario.binacchi at amarulasolutions.com>; Johan Jonker
> <jbx6244 at gmail.com>; Michal Simek <michal.simek at amd.com>; Arseniy
> Krasnov <avkrasnov at salutedevices.com>; Alexander Dahl <ada at thorsis.com>;
> William Zhang <william.zhang at broadcom.com>; Igor Prusov
> <ivprusov at salutedevices.com>; Meng, Tingting <tingting.meng at intel.com>;
> Chee, Tien Fong <tien.fong.chee at intel.com>; Hea, Kok Kiang
> <kok.kiang.hea at intel.com>; Ng, Boon Khai <boon.khai.ng at intel.com>; Yuslaimi,
> Alif Zakuan <alif.zakuan.yuslaimi at intel.com>; Zamri, Muhammad Hazim Izzat
> <muhammad.hazim.izzat.zamri at intel.com>; Lim, Jit Loon
> <jit.loon.lim at intel.com>; Tang, Sieu Mun <sieu.mun.tang at intel.com>
> Subject: Re: [resend v3 17/19] drivers: mtd: nand: Enabled Kconfig and Makefile
> for SPL_NAND_FRAMEWORK
> 
> Hi
> 
> On Wed, Feb 26, 2025 at 5:20 PM <dinesh.maniyam at intel.com> wrote:
> >
> > From: Dinesh Maniyam <dinesh.maniyam at intel.com>
> >
> > Enable the Kconfig and Makefile for the SPL_NAND_FRAMEWORK support in
> > agilex5 family device. This will include all the basic files needed to
> > use the existing nand spl support.
> >
> > Signed-off-by: Dinesh Maniyam <dinesh.maniyam at intel.com>
> > ---
> >  drivers/mtd/nand/raw/Kconfig  |  7 +++++++
> > drivers/mtd/nand/raw/Makefile | 10 ++++++++++
> >  2 files changed, 17 insertions(+)
> >
> > diff --git a/drivers/mtd/nand/raw/Kconfig
> > b/drivers/mtd/nand/raw/Kconfig index a9515c7b74..d6ac730224 100644
> > --- a/drivers/mtd/nand/raw/Kconfig
> > +++ b/drivers/mtd/nand/raw/Kconfig
> > @@ -837,4 +837,11 @@ config SYS_NAND_HW_ECC_OOBFIRST
> >
> >  endif  # if SPL
> >
> > +config SPL_NAND_FRAMEWORK
> > +       bool "Compile the entire NAND framework into the SPL"
> > +       help
> > +         Some drivers require a lot of functionality from the NAND framework
> > +         core when used in SPL. This option allows compiling the full NAND
> > +         framework into the SPL instead of it's reduced version.
> > +
> 
> This seems not relevant for this series and even I don't like the idea to have it
> 
> Michael
> 

I agree. I can drop this commit. 
We already have configs to enable the necessary files to be part SPL nand build.
However, dropping this commit will cause a compilation failure,
To overcome this, shall modify the socfpga_agilex5_nand2_defconfig and 
mtd/nand/raw/Kconfig files to include the relevant files to be part of the
SPL nand build.
Would you like me to resubmit patch 13 & patch 16?

Dinesh

> >  endif  # if MTD_RAW_NAND
> > diff --git a/drivers/mtd/nand/raw/Makefile
> > b/drivers/mtd/nand/raw/Makefile index 58fde3272f..0a32e184dc 100644
> > --- a/drivers/mtd/nand/raw/Makefile
> > +++ b/drivers/mtd/nand/raw/Makefile
> > @@ -3,8 +3,18 @@
> >  # (C) Copyright 2006
> >  # Wolfgang Denk, DENX Software Engineering, wd at denx.de.
> >
> > +nand-framework-objs := nand.o nand_bbt.o nand_ids.o nand_util.o \
> > +                      nand_ecc.o nand_base.o nand_timings.o nand_amd.o \
> > +                      nand_hynix.o nand_macronix.o nand_micron.o \
> > +                      nand_samsung.o nand_toshiba.o
> > +
> >  ifdef CONFIG_SPL_BUILD
> >
> > +ifdef CONFIG_SPL_NAND_FRAMEWORK
> > +obj-y += $(nand-framework-objs)
> > +NORMAL_DRIVERS=y
> > +endif
> > +
> >  ifdef CONFIG_SPL_NAND_DRIVERS
> >  NORMAL_DRIVERS=y
> >  endif
> > --
> > 2.19.0
> >
> 
> 
> --
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> michael at amarulasolutions.com
> __________________________________
> 
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172
> info at amarulasolutions.com www.amarulasolutions.com