[PATCH 2/2] board: xilinx: update guid based on metadata

[Sughosh Ganu]

On Mon, 16 Jun 2025 at 15:15, Padmarao Begari <padmarao.begari at amd.com> wrote:
>
> The generated GUID applies to all Xilinx platforms but is not
> specific to any individual board. For FWU multi bank update,
> use the image UUID (GUID) from the FWU metadata structure
> rather than embedding a generated GUID into the U-Boot build.
>
> Signed-off-by: Padmarao Begari <padmarao.begari at amd.com>
> ---
>  board/xilinx/common/board.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/board/xilinx/common/board.c b/board/xilinx/common/board.c
> index 8ffe7429901..3d22149d429 100644
> --- a/board/xilinx/common/board.c
> +++ b/board/xilinx/common/board.c
> @@ -712,3 +712,16 @@ phys_addr_t board_get_usable_ram_top(phys_size_t total_size)
>  }
>
>  #endif
> +
> +#if defined(CONFIG_FWU_MULTI_BANK_UPDATE)
> +int fwu_mtd_platform_hook(struct udevice *dev, struct fwu_data *data)
> +{
> +       struct fwu_image_entry *img_entry = &data->fwu_images[0];
> +
> +       /* Copy image type GUID */
> +       memcpy(&fw_images[0].image_type_id, &img_entry->image_type_guid, 16);

As we had discussed this offline, this is not a robust thing to do as
the FWU metadata is not secure, whereas the U-Boot image might be
booted as part of a trusted boot chain. This should be highlighted at
least with a comment saying so.

-sughosh

> +
> +       return 0;
> +}
> +
> +#endif
> --
> 2.25.1
>