[PATCH v5 03/12] drivers: i3c: Add i3c uclass driver.

[Maniyam, Dinesh]

Hi,

> -----Original Message-----
> From: Heiko Schocher <hs at denx.de>
> Sent: Saturday, 12 July 2025 4:14 pm
> To: Maniyam, Dinesh <dinesh.maniyam at altera.com>; u-boot at lists.denx.de
> Cc: Marek <marex at denx.de>; Simon <simon.k.r.goldschmidt at gmail.com>;
> Simon Glass <sjg at chromium.org>; Tom Rini <trini at konsulko.com>; Dario
> Binacchi <dario.binacchi at amarulasolutions.com>; Ilias Apalodimas
> <ilias.apalodimas at linaro.org>; Heinrich Schuchardt <xypron.glpk at gmx.de>;
> Jerome Forissier <jerome.forissier at linaro.org>; Mattijs Korpershoek
> <mkorpershoek at baylibre.com>; Ibai Erkiaga <ibai.erkiaga-elorza at amd.com>;
> Michal Simek <michal.simek at amd.com>; Dmitry Rokosov
> <ddrokosov at salutedevices.com>; Jonas Karlman <jonas at kwiboo.se>; Sebastian
> Reichel <sebastian.reichel at collabora.com>; Tingting Meng
> <tingting.meng at altera.com>; Chee, Tien Fong <tien.fong.chee at altera.com>;
> Hea, Kok Kiang <kok.kiang.hea at altera.com>; Ng, Boon Khai
> <boon.khai.ng at altera.com>; Yuslaimi, Alif Zakuan
> <alif.zakuan.yuslaimi at altera.com>; Hazim
> <muhammad.hazim.izzat.zamri at altera.com>; Lim, Jit Loon
> <jit.loon.lim at altera.com>
> Subject: Re: [PATCH v5 03/12] drivers: i3c: Add i3c uclass driver.
> 
> [CAUTION: This email is from outside your organization. Unless you trust the
> sender, do not click on links or open attachments as it may be a fraudulent email
> attempting to steal your information and/or compromise your computer.]
> 
> Hello Dinesh,
> 
> On 13.05.25 12:19, dinesh.maniyam at altera.com wrote:
> > From: Dinesh Maniyam <dinesh.maniyam at altera.com>
> >
> > Enable i3c general uclass driver. This uclass driver will have genaral
> > read and write api to call the specific i3c driver.
> >
> > Signed-off-by: Dinesh Maniyam <dinesh.maniyam at altera.com>
> > ---
> >   doc/api/i3c.rst          |  8 +++++
> >   doc/api/index.rst        |  1 +
> >   drivers/i3c/i3c-uclass.c | 38 +++++++++++++++++++++++
> >   include/dw-i3c.h         |  1 +
> >   include/i3c.h            | 67 ++++++++++++++++++++++++++++++++++++++++
> >   5 files changed, 115 insertions(+)
> >   create mode 100644 doc/api/i3c.rst
> >   create mode 100644 drivers/i3c/i3c-uclass.c
> >   create mode 100644 include/i3c.h
> 
> Patch drops error in CI:
> 
> https://dev.azure.com/hs0298/hs/_build/results?buildId=179&view=logs&j=8a06
> d10a-f6aa-5571-1476-f02da1a95f96&t=90bc975e-aa28-5566-cec3-
> 344578c5a53d&l=146
> 
> 
> ./include/i3c.h:54: warning: Function parameter or member 'read' not described
> in 'dm_i3c_ops'
> ./include/i3c.h:54: warning: Function parameter or member 'write' not described
> in 'dm_i3c_ops'
> 
> Please fix this, beside of this, I tend to pic kup the series, just one nitpick on
> another patch.
> 
> bye,
> Heiko
> 

Sure, let me fix this.

Regards
Dinesh

> --
> DENX Software Engineering GmbH, Managing Director: Johanna Denk, Tabea Lutz
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de