[PATCH] Revert "spi: cadence_qspi: Fix odd byte write issue in STIG mode"

Neha Malcom Francis n-francis at ti.com
Wed Jul 16 09:41:00 CEST 2025


Hi Prasanth

On 16/07/25 12:34, Prasanth Babu Mantena wrote:
> The buffer that is being used to write into the flash needs
> to be handled properly with padding of 0xFF. The place that
> this is done can be at a more generic place like spi-nor core.
> 
> This reverts commit cd9123507003e07b13e61d72e14e493bb338e827.
> 
> Signed-off-by: Prasanth Babu Mantena <p-mantena at ti.com>
> ---
>  drivers/spi/cadence_qspi_apb.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadence_qspi_apb.c
> index 6f89d3add5d..4696c09f754 100644
> --- a/drivers/spi/cadence_qspi_apb.c
> +++ b/drivers/spi/cadence_qspi_apb.c
> @@ -558,9 +558,6 @@ int cadence_qspi_apb_command_write(struct cadence_spi_priv *priv,
>  	void *reg_base = priv->regbase;
>  	u8 opcode;
>  
> -	if (priv->dtr)
> -		txlen += txlen & 1;
> -
>  	if (priv->dtr)
>  		opcode = op->cmd.opcode >> 8;
>  	else

After reading [0], makes sense.

Reviewed-by: Neha Malcom Francis <n-francis at ti.com>

[0]
https://lore.kernel.org/u-boot/174963a1-bf6e-4e54-9946-bf3c42a72960@amd.com/

-- 
Thanking You
Neha Malcom Francis


More information about the U-Boot mailing list