[PATCH 1/3] mmc: s5p_sdhci: remove duplicated card detect code
Anand Moon
linux.amoon at gmail.com
Tue Jul 22 09:33:15 CEST 2025
Hi Henrik,
On Sun, 20 Jul 2025 at 22:40, Henrik Grimler <henrik at grimler.se> wrote:
>
> The common sdhci infrastructure is already parsing the cd-gpios
> property, since commit 451931ea7002 ("mmc: sdhci: Read cd-gpio from
> devicetree"). The s5p code is therefore duplicated, and also broken
> since it assumes that the GPIO value is inverted, while the sdhci code
> correctly follows the ACTIVE_LOW/ACTIVE_HIGH flag specified in the
> device tree.
>
> This fix was originally authored by Simon Shields:
> https://github.com/fourkbomb/u-boot/commit/2eac9dea7903
>
> The change has been tested on exynos4210-i9100, a device similar to
> exynos4210-trats.
>
> Signed-off-by: Henrik Grimler <henrik at grimler.se>
Reviewed-by: Anand Moon <linux.amoon at gmail.com>
Thanks
-Anand
More information about the U-Boot
mailing list