[PATCH] mtd: spi-nor-ids: Add support for Winbond W77Q51NW

[Marek Vasut]

On 7/22/25 11:20 AM, Tudor Ambarus wrote:
> 
> 
> On 7/20/25 8:58 PM, Marek Vasut wrote:
>> Add IDs for Winbond W77Q51NW, 512M-bit Secure Serial Flash Memory
>> with Post-Quantum Cryptography, Dual/Quad SPI, QPI and DTR . The
>> flash part is similar to W25Q512NWM .
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
>> ---
>> Cc: Jagan Teki <jagan at amarulasolutions.com>
>> Cc: Nobuhiro Iwamatsu <iwamatsu at nigauri.org>
>> Cc: Takahiro Kuwano <Takahiro.Kuwano at infineon.com>
>> Cc: Tom Rini <trini at konsulko.com>
>> Cc: Tudor Ambarus <tudor.ambarus at linaro.org>
>> Cc: Venkatesh Yadav Abbarapu <venkatesh.abbarapu at amd.com>
>> Cc: Vignesh R <vigneshr at ti.com>
>> Cc: u-boot at lists.denx.de
>> ---
>>   drivers/mtd/spi/spi-nor-ids.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
>> index e7e97780d7c..0383175beb5 100644
>> --- a/drivers/mtd/spi/spi-nor-ids.c
>> +++ b/drivers/mtd/spi/spi-nor-ids.c
>> @@ -591,6 +591,7 @@ const struct flash_info spi_nor_ids[] = {
>>   	{ INFO("w25m512jw", 0xef6119, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>>   	{ INFO("w25m512jv", 0xef7119, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>>   	{ INFO("w25h02jv", 0xef9022, 0, 64 * 1024, 4096, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>> +	{ INFO("w77q51nw", 0xef8a1a, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
> 
> 
> The patch is looking fine. Any idea why SFDP parsing is optional?

I suspect to reduce SPL size on platforms where SPL runs into SRAM size 
constraints .

> I see a SPI_FLASH_SFDP_SUPPORT that guards it. Having SFDP optional
> introduces headaches as one has to specify all flash parameters statically
> at flash declaration. I assume it's about image size limitation. I also
> see a spi-nor-tiny.c, about which I'm not thrilled. Is there a general
> recommendation on when to split things? Maybe a question for Tom.

SPL is probably non-SFDP , unless the SRAM is big.
U-Boot should be SFDP if possible.

> Here it seems that you specify just data that can be discovered by SFDP.
> You won't need a flash entry at all if one adds a "spi-nor-generic"
> flash info that initializes the flash solely on its SFDP data, see
> linux. It would require porting the parsing of the 4bait table from
> linux and other small changes for the rest of parameters.
Or maybe synchronize the entire framework again ?