[PATCH] clk: cdce9xx: Remove always true test

Andrew Goodbody andrew.goodbody at linaro.org
Wed Jul 23 17:17:28 CEST 2025


The function dev_read_u32_default does not return an error and the
variable 'val' is unsigned so testing for >= 0 will always be true so
remove this test.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
---
 drivers/clk/clk-cdce9xx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clk/clk-cdce9xx.c b/drivers/clk/clk-cdce9xx.c
index e5f74e714d5..492a196604a 100644
--- a/drivers/clk/clk-cdce9xx.c
+++ b/drivers/clk/clk-cdce9xx.c
@@ -117,8 +117,7 @@ static int cdce9xx_clk_probe(struct udevice *dev)
 	data->xtal_rate = clk_get_rate(&clk);
 
 	val = dev_read_u32_default(dev, "xtal-load-pf", -1);
-	if (val >= 0)
-		cdce9xx_reg_write(dev, CDCE9XX_REG_XCSEL, val << 3);
+	cdce9xx_reg_write(dev, CDCE9XX_REG_XCSEL, val << 3);
 
 	return 0;
 }

---
base-commit: bd0ade7d090a334b3986936d63a34001d99722ad
change-id: 20250723-cdce9xx_clk-9e1008c78db7

Best regards,
-- 
Andrew Goodbody <andrew.goodbody at linaro.org>



More information about the U-Boot mailing list