[PATCH v1 0/2] Improve EFI partition matching for capsule update
Casey Connolly
casey.connolly at linaro.org
Fri Jul 25 15:17:54 CEST 2025
Hi Balaji,
On 24/07/2025 11:00, Balaji Selvanathan wrote:
> This patch series improves the reliability of EFI capsule updates by
> fixing issues in device path matching and partition name filtering.
>
> The first patch updates the logic in find_handle() to correctly match
> device paths when the EFI System Partition (ESP) is a sub-partition
> within a larger boot device. Previously, the function only compared
> paths when the candidate path was shorter or equal in length to the
> input path.
> This caused failures when the ESP path was longer, as is
> common when the ESP resides inside a UFS LUN. The new logic allows
> matching when the input path is a prefix of the candidate path,
> ensuring the correct EFI handle is returned for accessing the ESP
> during capsule updates.
>
> The second patch fixes a bug in 'capsule_update.c' where the logic
> was incorrectly matching partitions like 'uefisecapps_a' when it
> intended to match only 'uefi_a' or 'uefi_b'. This prevents flashing
> to unintended partitions.
>
> Together, these changes improve the correctness and safety of the
> capsule update process on Snapdragon platforms.
Same deal as in patch 2, this isn't an essay. Please refer to
https://www.kernel.org/doc/html/v5.10/process/submitting-patches.html#describe-your-changes
Specifically "Describe your changes in imperative mood", you shouldn't
need to use the words "patch" or "patch series". Compare to [1] for
example. Save the technical details for the commit messages and use the
cover letter to provide a brief overview of what the series does to the
codebase.
[1]:
https://lore.kernel.org/u-boot/20250618-sm6350-bringup-v1-0-3cc22aab7a7a@fairphone.com
Kind regards,
>
> Balaji Selvanathan (2):
> efi_loader: improve device path matching for partition lookup
> capsule_update: fix partition match to exclude uefisecapps
>
> arch/arm/mach-snapdragon/capsule_update.c | 2 +-
> lib/efi_loader/efi_device_path.c | 62 ++++++++++++++++-------
> lib/efi_loader/efi_disk.c | 2 +-
> 3 files changed, 46 insertions(+), 20 deletions(-)
>
--
// Casey (she/her)
More information about the U-Boot
mailing list