[PATCH 1/1] tools: mkeficapsule: resource leak in read_bin_file()

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Sat Jul 26 08:31:23 CEST 2025


Free the allocated buffer in case of an error.

Fixes: 9e63786e2b4b ("tools: mkeficapsule: rework the code a little bit")
Addresses-Coverity-ID: 345917 Resource leak
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
---
 tools/mkeficapsule.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/mkeficapsule.c b/tools/mkeficapsule.c
index fb6c57f77c1..0f41cdb64f5 100644
--- a/tools/mkeficapsule.c
+++ b/tools/mkeficapsule.c
@@ -168,6 +168,7 @@ static int read_bin_file(char *bin, uint8_t **data, off_t *bin_size)
 	if (size < bin_stat.st_size) {
 		fprintf(stderr, "read failed (%zx)\n", size);
 		ret = -1;
+		free(buf);
 		goto err;
 	}
 
-- 
2.50.0



More information about the U-Boot mailing list