[PATCH v3 1/2] binman: bintool: use apt-get instead of apt

[Neha Malcom Francis]

Hi Jerome

On 24/07/25 14:42, Jerome Forissier wrote:
> The 'apt' command is not meant to be used in scripts or tools. Please
> see the man page [1] for details. Therefore, use 'apt-get' instead.
> This avoids the following warning:
> 
> WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
> 
> [1] https://manpages.debian.org/bookworm/apt/apt.8.en.html#SCRIPT_USAGE_AND_DIFFERENCES_FROM_OTHER_APT_TOOLS
> 
> Signed-off-by: Jerome Forissier <jerome.forissier at linaro.org>
> ---
> 
> (no changes since v1)
> 
>  tools/binman/bintool.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/binman/bintool.py b/tools/binman/bintool.py
> index 81872db377f..f46bb52a7b3 100644
> --- a/tools/binman/bintool.py
> +++ b/tools/binman/bintool.py
> @@ -421,7 +421,7 @@ class Bintool:
>          Returns:
>              True, assuming it completes without error
>          """
> -        args = ['sudo', 'apt', 'install', '-y', package]
> +        args = ['sudo', 'apt-get', 'install', '-y', package]
>          print('- %s' % ' '.join(args))
>          tools.run(*args)
>          return True

Reviewed-by: Neha Malcom Francis <n-francis at ti.com>

-- 
Thanking You
Neha Malcom Francis