[PATCH 2/2] mmc: octeontx_hsmmc: Remove impossible test

Andrew Goodbody andrew.goodbody at linaro.org
Thu Jul 31 12:51:22 CEST 2025


In octeontx_mmc_io_drive_setup drive and slew are tested for being less
than 0 but they are declared as uint fields so this test must always
fail. Just remove the test.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody at linaro.org>
---
 drivers/mmc/octeontx_hsmmc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/mmc/octeontx_hsmmc.c b/drivers/mmc/octeontx_hsmmc.c
index ffc8d4c7874..bb4fb29424b 100644
--- a/drivers/mmc/octeontx_hsmmc.c
+++ b/drivers/mmc/octeontx_hsmmc.c
@@ -2828,9 +2828,6 @@ static void octeontx_mmc_io_drive_setup(struct mmc *mmc)
 		struct octeontx_mmc_slot *slot = mmc_to_slot(mmc);
 		union mio_emm_io_ctl io_ctl;
 
-		if (slot->drive < 0 || slot->slew < 0)
-			return;
-
 		io_ctl.u = 0;
 		io_ctl.s.drive = slot->drive;
 		io_ctl.s.slew = slot->slew;

-- 
2.39.5



More information about the U-Boot mailing list