[PATCH v1 1/5] binman: Fix FIT image overlap issues

[Yannic Moog]

Am Dienstag, dem 29.07.2025 um 12:48 +0000 schrieb Aristo Chen:
> Fix three binman tests that has memory region overlap issue, the test
> cases needed to be updated to use non-overlapping memory layouts.
> 
> * Tests fixed:
>   - testFitFirmwareLoadables
>   - testFitSignSimple
>   - testFitSignNoSingatureNodes
> 
> * Changes made:
>   Updated DTB test files to change U-Boot load addresses from 0x0 to
>   0x2000 to avoid overlapping with ATF in the 0x10-0xfc range:
>   - 276_fit_firmware_loadables.dts
>   - 340_fit_signature.dts
>   - 342_fit_signature.dts

Can you add the info that elf_sections.lds sets the load addr of the atf (in
this case) to the commit description.
Also, for anyone not familiar with elf files, can you add to the doc
(tools/binman/entries.rst, fit,load) info on how to find out where the elf is
loaded? It is not immediately obvious in binman section of U-Boot dts files and
this may help users debug quicker when they have a conflict as highlighed with
this patch series.

Yannic

> 
> An upcoming commit will validate if the memory region is overlapped
> 
> Signed-off-by: Aristo Chen <aristo.chen at canonical.com>
> ---
>  tools/binman/test/276_fit_firmware_loadables.dts | 4 ++--
>  tools/binman/test/340_fit_signature.dts          | 4 ++--
>  tools/binman/test/342_fit_signature.dts          | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/binman/test/276_fit_firmware_loadables.dts
> b/tools/binman/test/276_fit_firmware_loadables.dts
> index 2f79cdc9bb8..d344036a11a 100644
> --- a/tools/binman/test/276_fit_firmware_loadables.dts
> +++ b/tools/binman/test/276_fit_firmware_loadables.dts
> @@ -19,8 +19,8 @@
>  					arch = "arm64";
>  					os = "u-boot";
>  					compression = "none";
> -					load = <0x00000000>;
> -					entry = <0x00000000>;
> +					load = <0x00002000>;
> +					entry = <0x00002000>;
>  
>  					u-boot-nodtb {
>  					};
> diff --git a/tools/binman/test/340_fit_signature.dts
> b/tools/binman/test/340_fit_signature.dts
> index 9dce62e52de..1c25d52cba4 100644
> --- a/tools/binman/test/340_fit_signature.dts
> +++ b/tools/binman/test/340_fit_signature.dts
> @@ -20,8 +20,8 @@
>  					arch = "arm64";
>  					os = "u-boot";
>  					compression = "none";
> -					load = <0x00000000>;
> -					entry = <0x00000000>;
> +					load = <0x00002000>;
> +					entry = <0x00002000>;
>  
>  					u-boot-nodtb {
>  					};
> diff --git a/tools/binman/test/342_fit_signature.dts
> b/tools/binman/test/342_fit_signature.dts
> index 267105d0f68..2ac600b1c70 100644
> --- a/tools/binman/test/342_fit_signature.dts
> +++ b/tools/binman/test/342_fit_signature.dts
> @@ -20,8 +20,8 @@
>  					arch = "arm64";
>  					os = "u-boot";
>  					compression = "none";
> -					load = <0x00000000>;
> -					entry = <0x00000000>;
> +					load = <0x00002000>;
> +					entry = <0x00002000>;
>  
>  					u-boot-nodtb {
>  					};