[PATCH 0/3] sntp for NET_LWIP

[Jerome Forissier]

Hi Tim,

On 5/30/25 17:46, Tim Harvey wrote:
> On Wed, May 21, 2025 at 8:15 AM Jerome Forissier
> <jerome.forissier at linaro.org> wrote:
>>
>> Implement the sntp command with lwIP (CONFIG_NET_LWIP=y). SNTP is
>> supported as an app in lib/lwip/lwip/src/apps/sntp/sntp.c so this is
>> mainly about adding that file to the build and writing do_sntp() to use
>> the sntp_*() API and run the receive & timer loop. There is a patch to
>> extract a small bit of common code from net/sntp.c to avoid duplication.
>> The QEMU arm64 lwIP defconfig is updated to provide the sntp command by
>> default for convenience.
>> I could not test the case when the NTP server IP is provided by DHCP. If
>> someone has access right away to such a configuration and in case it
>> does not work, please let me know.
>>
>>
>> Jerome Forissier (3):
>>   net: extract function net_sntp_set_rtc() from sntp_handler()
>>   net: lwip: add sntp command
>>   configs: qemu_arm64_lwip_defconfig: enable CMD_SNTP
>>
>>  cmd/Kconfig                       |  13 +--
>>  cmd/net-lwip.c                    |   5 ++
>>  configs/qemu_arm64_lwip_defconfig |   1 +
>>  include/net-common.h              |  13 +++
>>  lib/lwip/Makefile                 |   1 +
>>  lib/lwip/u-boot/arch/cc.h         |   4 +
>>  lib/lwip/u-boot/lwipopts.h        |   4 +
>>  net/lwip/Makefile                 |   1 +
>>  net/lwip/sntp.c                   | 128 ++++++++++++++++++++++++++++++
>>  net/net-common.c                  |  28 +++++++
>>  net/sntp.c                        |  23 +-----
>>  11 files changed, 195 insertions(+), 26 deletions(-)
>>  create mode 100644 net/lwip/sntp.c
>>
> 
> Hi Jerome,
> 
> Thanks for the continued work on lwIP!

Sure. Thank you for testing and fixing bugs :)
 
> For the series:
> Reviewed-by: Tim Harvey <tharvey at gateworks.com>
> 
> Note that if this is merged before my series we'll want to have a
> followup that removes the sys_check_timeouts() after net_lwip_rx(udev,
> netif), or if it is merged before my series I can send a v3 that does
> it.

Both series are in my patchwork queue, so I'll take care of that. Thanks
for the heads up.

> Do you have a list of lwIP features you're still working on? I'm going
> to be moving the Gateworks venice boards to it as things look pretty
> good. The only thing I saw that was missing was TFTPPUT which I don't
> really care about.

I don't have any thing left in my to-do list for lwIP at the moment. There
are several U-Boot features that are still not supported with NET_LWIP. As
you said TFTP PUT but also IPv6, the bootp command, as well as ncsi, ethsw,
and wol (those are found in cmd/Kconfig). Maybe other things, I don't know.

BR,
-- 
Jerome

> 
> Best Regards,
> 
> Tim