[PATCH v2 06/13] sandbox: test: update for CONFIG_CLK_AUTO_ID support

[Patrice CHOTARD]

On 5/27/25 15:27, Patrice Chotard wrote:
> From: Patrick Delaunay <patrick.delaunay at foss.st.com>
> 
> Update the existing test dm_test_clk_ccf() with new CLK_ID macro.
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay at foss.st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard at foss.st.com>
> Cc: Lukasz Majewski <lukma at denx.de>
> Cc: Sean Anderson <seanga2 at gmail.com>
> ---
> 
> (no changes since v1)
> 
>  test/dm/clk_ccf.c | 30 +++++++++++++++---------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/test/dm/clk_ccf.c b/test/dm/clk_ccf.c
> index ac56f17b775..64c21b10c3e 100644
> --- a/test/dm/clk_ccf.c
> +++ b/test/dm/clk_ccf.c
> @@ -32,13 +32,13 @@ static int dm_test_clk_ccf(struct unit_test_state *uts)
>  	ut_assertok(uclass_get_device_by_name(UCLASS_MISC, "clk-test", &test_dev));
>  
>  	/* Test for clk_get_by_id() */
> -	ret = clk_get_by_id(SANDBOX_CLK_ECSPI_ROOT, &clk);
> +	ret = clk_get_by_id(CLK_ID(dev, SANDBOX_CLK_ECSPI_ROOT), &clk);
>  	ut_assertok(ret);
>  	ut_asserteq_str("ecspi_root", clk->dev->name);
>  	ut_asserteq(CLK_SET_RATE_PARENT, clk->flags);
>  
>  	/* Test for clk_get_parent_rate() */
> -	ret = clk_get_by_id(SANDBOX_CLK_ECSPI1, &clk);
> +	ret = clk_get_by_id(CLK_ID(dev, SANDBOX_CLK_ECSPI1), &clk);
>  	ut_assertok(ret);
>  	ut_asserteq_str("ecspi1", clk->dev->name);
>  	ut_asserteq(CLK_SET_RATE_PARENT, clk->flags);
> @@ -47,7 +47,7 @@ static int dm_test_clk_ccf(struct unit_test_state *uts)
>  	ut_asserteq(rate, 20000000);
>  
>  	/* test the gate of CCF */
> -	ret = clk_get_by_id(SANDBOX_CLK_ECSPI0, &clk);
> +	ret = clk_get_by_id(CLK_ID(dev, SANDBOX_CLK_ECSPI0), &clk);
>  	ut_assertok(ret);
>  	ut_asserteq_str("ecspi0", clk->dev->name);
>  	ut_asserteq(CLK_SET_RATE_PARENT, clk->flags);
> @@ -56,7 +56,7 @@ static int dm_test_clk_ccf(struct unit_test_state *uts)
>  	ut_asserteq(rate, 20000000);
>  
>  	/* Test the mux of CCF */
> -	ret = clk_get_by_id(SANDBOX_CLK_USDHC1_SEL, &clk);
> +	ret = clk_get_by_id(CLK_ID(dev, SANDBOX_CLK_USDHC1_SEL), &clk);
>  	ut_assertok(ret);
>  	ut_asserteq_str("usdhc1_sel", clk->dev->name);
>  	ut_asserteq(CLK_SET_RATE_NO_REPARENT, clk->flags);
> @@ -70,7 +70,7 @@ static int dm_test_clk_ccf(struct unit_test_state *uts)
>  	rate = clk_get_rate(clk);
>  	ut_asserteq(rate, 60000000);
>  
> -	ret = clk_get_by_id(SANDBOX_CLK_PLL3_80M, &pclk);
> +	ret = clk_get_by_id(CLK_ID(dev, SANDBOX_CLK_PLL3_80M), &pclk);
>  	ut_assertok(ret);
>  
>  	ret = clk_set_parent(clk, pclk);
> @@ -79,7 +79,7 @@ static int dm_test_clk_ccf(struct unit_test_state *uts)
>  	rate = clk_get_rate(clk);
>  	ut_asserteq(rate, 80000000);
>  
> -	ret = clk_get_by_id(SANDBOX_CLK_USDHC2_SEL, &clk);
> +	ret = clk_get_by_id(CLK_ID(dev, SANDBOX_CLK_USDHC2_SEL), &clk);
>  	ut_assertok(ret);
>  	ut_asserteq_str("usdhc2_sel", clk->dev->name);
>  	ut_asserteq(CLK_SET_RATE_NO_REPARENT, clk->flags);
> @@ -97,7 +97,7 @@ static int dm_test_clk_ccf(struct unit_test_state *uts)
>  	rate = clk_get_rate(clk);
>  	ut_asserteq(rate, 80000000);
>  
> -	ret = clk_get_by_id(SANDBOX_CLK_PLL3_60M, &pclk);
> +	ret = clk_get_by_id(CLK_ID(dev, SANDBOX_CLK_PLL3_60M), &pclk);
>  	ut_assertok(ret);
>  
>  	ret = clk_set_parent(clk, pclk);
> @@ -107,7 +107,7 @@ static int dm_test_clk_ccf(struct unit_test_state *uts)
>  	ut_asserteq(rate, 60000000);
>  
>  	/* Test the composite of CCF */
> -	ret = clk_get_by_id(SANDBOX_CLK_I2C, &clk);
> +	ret = clk_get_by_id(CLK_ID(dev, SANDBOX_CLK_I2C), &clk);
>  	ut_assertok(ret);
>  	ut_asserteq_str("i2c", clk->dev->name);
>  	ut_asserteq(CLK_SET_RATE_UNGATE, clk->flags);
> @@ -124,12 +124,12 @@ static int dm_test_clk_ccf(struct unit_test_state *uts)
>  	ret = clk_get_by_index(test_dev, SANDBOX_CLK_TEST_ID_I2C_ROOT, &clk_ccf);
>  	ut_assertok(ret);
>  	ut_asserteq_str("clk-ccf", clk_ccf.dev->name);
> -	ut_asserteq(clk_ccf.id, SANDBOX_CLK_I2C_ROOT);
> +	ut_asserteq(clk_ccf.id, CLK_ID(clk_ccf.dev, SANDBOX_CLK_I2C_ROOT));
>  
> -	ret = clk_get_by_id(SANDBOX_CLK_I2C_ROOT, &clk);
> +	ret = clk_get_by_id(CLK_ID(dev, SANDBOX_CLK_I2C_ROOT), &clk);
>  	ut_assertok(ret);
>  	ut_asserteq_str("i2c_root", clk->dev->name);
> -	ut_asserteq(clk->id, SANDBOX_CLK_I2C_ROOT);
> +	ut_asserteq(clk_get_id(clk), SANDBOX_CLK_I2C_ROOT);
>  
>  	ret = clk_enable(&clk_ccf);
>  	ut_assertok(ret);
> @@ -137,7 +137,7 @@ static int dm_test_clk_ccf(struct unit_test_state *uts)
>  	ret = sandbox_clk_enable_count(clk);
>  	ut_asserteq(ret, 1);
>  
> -	ret = clk_get_by_id(SANDBOX_CLK_I2C, &pclk);
> +	ret = clk_get_by_id(CLK_ID(dev, SANDBOX_CLK_I2C), &pclk);
>  	ut_assertok(ret);
>  
>  	ret = sandbox_clk_enable_count(pclk);
> @@ -153,7 +153,7 @@ static int dm_test_clk_ccf(struct unit_test_state *uts)
>  	ut_asserteq(ret, 0);
>  
>  	/* Test clock re-parenting. */
> -	ret = clk_get_by_id(SANDBOX_CLK_USDHC1_SEL, &clk);
> +	ret = clk_get_by_id(CLK_ID(dev, SANDBOX_CLK_USDHC1_SEL), &clk);
>  	ut_assertok(ret);
>  	ut_asserteq_str("usdhc1_sel", clk->dev->name);
>  
> @@ -167,7 +167,7 @@ static int dm_test_clk_ccf(struct unit_test_state *uts)
>  		clkid = SANDBOX_CLK_PLL3_60M;
>  	}
>  
> -	ret = clk_get_by_id(clkid, &pclk);
> +	ret = clk_get_by_id(CLK_ID(dev, clkid), &pclk);
>  	ut_assertok(ret);
>  	ret = clk_set_parent(clk, pclk);
>  	ut_assertok(ret);
> @@ -176,7 +176,7 @@ static int dm_test_clk_ccf(struct unit_test_state *uts)
>  	ut_asserteq_str(clkname, pclk->dev->name);
>  
>  	/* Test disabling critical clock. */
> -	ret = clk_get_by_id(SANDBOX_CLK_I2C_ROOT, &clk);
> +	ret = clk_get_by_id(CLK_ID(dev, SANDBOX_CLK_I2C_ROOT), &clk);
>  	ut_assertok(ret);
>  	ut_asserteq_str("i2c_root", clk->dev->name);
>  
Reviewed-by: Patrice Chotard <patrice.chotard at foss.st.com>

Thanks
Patrice