[PATCH 00/12] drop volatile from global data

Tom Rini trini at konsulko.com
Thu Jun 5 00:47:41 CEST 2025


On Wed, Jun 04, 2025 at 02:07:02PM -0600, Tom Rini wrote:
> On Wed, Jun 04, 2025 at 09:56:00PM +0200, Rasmus Villemoes wrote:
> > There's really no reason for the gd pointer to have the volatile
> > qualifier.
> > 
> > In fact, I claim that it's completely unnecessary and just pessimizes
> > code generation and forces ugly casts in lots of places. For example,
> > see the casts in drivers/core/tag.c where elements are added to
> > gd->dm_taglist, or a helper such as cyclic_get_list() that should not
> > be needed.
> > 
> > Also, it is what ends up standing in the way of an otherwise
> > innocent code cleanup of list.h:
> > https://lore.kernel.org/u-boot/20250522165656.GB2179216@bill-the-cat/
> > 
> > Note that riscv, x86 as well as arm64 with LTO enabled has not had
> > this volatile qualifier, so it's unlikely there's any generic code
> > that depends on it.
> > 
> > CI seems mostly happy:
> > 
> >   https://github.com/u-boot/u-boot/pull/775/checks?check_run_id=43463083829
> > 
> > The one failing test seems to be an infrastructure thing unrelated to
> > these patches ("docker: filesystem layer verification failed for
> > digest
> > sha256:379cc6cd06dc3fc80e31d5170204c0cfcc25cb3b3ad457ced23bed2b38ec9f36")
> 
> Azure seems to be having some hiccups, sadly. I know from my end I can't
> hit "rerun failed jobs", is there an option visible to you like that?

Ah, this was a different Azure problem (I was looking like I was logged
in and authorized, but was in fact not authorized) so I hit the retry
failed jobs button now.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250604/414b14dd/attachment.sig>


More information about the U-Boot mailing list