[PATCH] Revert "caam: Fix CAAM error on startup"

[Tom Rini]

On Thu, Jun 05, 2025 at 07:52:44AM -0300, Fabio Estevam wrote:

> This reverts commit 159b6f0e119962ce5da645f548cefe9196c8778e.
> 
> Since commit 159b6f0e1199 ("caam: Fix CAAM error on startup") the following
> regression was reported by Tim Harvey:
> 
> "I've found that this patch causes a regression on an imx8mm board
> (imx8mm_venice_defconfig) where the first call to caam_rng_read fails
> here in jr_dequeue but if you call it again it works. With some
> debugging added:
> SEC0:  RNG instantiated
> ...
> Hit any key to stop autoboot:  0
> u-boot=> rng list
> RNG #0 - caam-rng
> u-boot=> rng 0 10
> caam_rng_read caam-rng len=16
> run_descriptor_jr_idx idx=0
> Error in SEC deq: -1
> caam_rng_read_one run_descriptor_jr failed: -1
> caam_rng_read caam-rng caam_rng_read_one failed: -5
> Reading RNG failed
> u-boot=> rng 0 10
> caam_rng_read caam-rng len=16
> run_descriptor_jr_idx idx=0
> 00000000: ad 2e ad c0 2a 12 27 c4 65 82 66 19 be ef f6 07  ....*.'.e.f.....
> 
> If I revert your patch caam_rng_read works initially and on subsequent
> calls."
> 
> " I ran into this when I was testing
> lwIP HTTPS as it causes anything that uses dm_rng to fail the first
> time (such as HTTPS)."
> 
> Revert it for now to avoid the regression.
> 
> Reported-by: Tim Harvey <tharvey at gateworks.com>
> Signed-off-by: Fabio Estevam <festevam at gmail.com>

I would like to wait a day or two before merging this, to give the
original author a chance to chime in but I would like to see this for
-rc4 this coming Monday (unless there's an active thread on fixing the
problem for everyone, in which case we just need that resulting fix for
the release..). Thanks all!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250605/9b06a766/attachment.sig>