[PATCH v4 4/5] rockchip: rk3399-nanopi-4: Allow MMC driver to control SD regulators

[Kever Yang]

On 2025/5/24 00:53, Justin Klaassen wrote:
> This change removes the "regulator-always-on" property from the
> "vcc3v0_sd" (vmmc-supply) and "vcc_sdio" (vqmmc-supply) regulators,
> which otherwise prevents the MMC driver from being able to power cycle
> the SD card as part of the initialization procedure.
>
> It also removes the "regulator-boot-on" from the "vcc_sdio" regulator,
> which could theoretically damage a SD card that is already initialized
> in a low voltage mode.
>
> Signed-off-by: Justin Klaassen <justin at tidylabs.net>
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - Added patch to remove device-tree properties that conflicted with MMC driver initialization
>
>   arch/arm/dts/rk3399-nanopi4-u-boot.dtsi | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-nanopi4-u-boot.dtsi b/arch/arm/dts/rk3399-nanopi4-u-boot.dtsi
> index 75736124996..ba2b73223d4 100644
> --- a/arch/arm/dts/rk3399-nanopi4-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-nanopi4-u-boot.dtsi
> @@ -19,8 +19,11 @@
>   
>   &vcc3v0_sd {
>   	bootph-pre-ram;
> +	/delete-property/ regulator-always-on;
>   };
>   
>   &vcc_sdio {
> +	/delete-property/ regulator-always-on;
> +	/delete-property/ regulator-boot-on;
>   	regulator-init-microvolt = <3000000>;
>   };