[PATCH v2] env: mmc: fix offsets relative to the end of the partition
Andrew Goodbody
andrew.goodbody at linaro.org
Fri Jun 6 12:49:59 CEST 2025
On 06/06/2025 10:45, Quentin Schulz wrote:
> Hi Michael,
>
> On 6/5/25 9:46 AM, Michael Walle wrote:
>> According to the help text, you can set negative offsets to indicated
>
> s/indicated/indicate/
>
>> that the offset is relative to the end of the parition. But kconfig
>
> s/parition/partition/
>
>> doesn't let you specify negative hex values. I think this fell through
>> the cracks when converting the symbol from a '#define' to a kconfig
>> option.
>>
>
> Maybe a Fixes: tag would be nice there, but since we don't have stable
> releases like the kernel, not sure it matters much :)
Please always include a Fixes tag when appropriate.
Thank you,
Andrew
>> Introduce a new boolean kconfig option to switch on the "relative to the
>> end" behavior.
>>
>> Signed-off-by: Michael Walle <mwalle at kernel.org>
>
> Not sure about the ramifications, but the change looks reasonable to me,
> so:
>
> Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>
>
> Maybe we should have some test for that to make sure it works as
> expected and keeps working as expected?
>
> Thanks!
> Quentin
More information about the U-Boot
mailing list