[PATCH v2 1/3] verdin-am62p: include linux/sizes.h

Francesco Dolcini francesco at dolcini.it
Sun Jun 8 10:33:15 CEST 2025


Hi Heinrich,
thanks for the patch.

On Sun, Jun 08, 2025 at 09:42:26AM +0200, Heinrich Schuchardt wrote:
> Avoid build failures
> 
> In file included from include/config.h:3,
>                  from board/toradex/verdin-am62p/verdin-am62p.c:9:
> board/toradex/verdin-am62p/verdin-am62p.c: In function 'dram_init':
> include/configs/verdin-am62p.h:13:33: error: 'SZ_2G' undeclared (first use in this function)
>    13 | #define CFG_SYS_SDRAM_SIZE      SZ_2G /* Maximum supported size */
>       |                                 ^~~~~
> board/toradex/verdin-am62p/verdin-am62p.c:63:65: note: in expansion of macro 'CFG_SYS_SDRAM_SIZE'
>    63 |         gd->ram_size = get_ram_size((long *)CFG_SYS_SDRAM_BASE, CFG_SYS_SDRAM_SIZE);
>       |                                                                 ^~~~~~~~~~~~~~~~~~
> include/configs/verdin-am62p.h:13:33: note: each undeclared identifier is reported only once for each function it appears in
> board/toradex/verdin-am62p/verdin-am62p.c:65:28: error: 'SZ_1G' undeclared (first use in this function)
>    65 |         if (gd->ram_size < SZ_1G)
>       |                            ^~~~~
> 

Why do you have a build error in verdin-am62p.c, given that linux/sizes.h
is already included there?

The change in verdin-am62p.h is obviously fine, yet I do not understand
what's going on.

I just tried building u-boot next branch, with both
verdin-am62p_a53_defconfig and verdin-am62p_r5_defconfig and I did not
have any build error, using arm/arm64 cross gcc from debian stable on
x86-64.

In any case, given the change in verdin-am62p.h is correct to me,

Acked-by: Francesco Dolcini <francesco.dolcini at toradex.com>

Francesco



More information about the U-Boot mailing list