[PATCH v2 07/13] lwip: dns: do not print IP address when a variable is specified

[Jerome Forissier]

On 6/6/25 16:19, Tom Rini wrote:
> On Fri, Jun 06, 2025 at 08:41:43AM +0200, Jerome Forissier wrote:
> 
>> When calling "dns <hostname> <varname>", do not print out the IP address
>> of <hostname> onto the console. Print it only when no variable is
>> passed. The reason is to be able to call do_dns() from another command
>> in need of the DNS services without polluting the output.
>>
>> Signed-off-by: Jerome Forissier <jerome.forissier at linaro.org>
> 
> As I do not know off-hand, how does this compare with other commands
> which can be used to set a variable? I assume it's similar.

Yes, it seems to be a general pattern. For example:
- 'part list <interface> <dev> [flags] <varname>', see do_part_list() (and
other sub-commands as well)
- 'op count [*]src1 [*]src2 [[*]dest]', see do_binop()
- 'sm reboot_reason [name]', see do_sm_reboot_reason()
etc.

> And then,
> oh, we don't have doc/cmd/usage/dns.rst to start with. So, follow-up to
> this series please, document the network commands that we have in both
> lwip and legacy stack and please note where there's differences if any.

Added to my to-do list ;)

Thanks,
-- 
Jerome