[PATCH v2 1/3] i2c: geni: fix error message wording in clk_disable

[Heiko Schocher]

Hello Casey,

On 10.06.25 18:50, Casey Connolly wrote:
> Correct the error messages so they accurately describe that we failed to
> disable the clocks, not to enable them.
> 
> Signed-off-by: Casey Connolly <casey.connolly at linaro.org>
> Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>
> ---
>   drivers/i2c/geni_i2c.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/i2c/geni_i2c.c b/drivers/i2c/geni_i2c.c
> index eabf5c76c21c2bc12c80dbb9fb498a0080928248..4eb41ba852f7790ca646c8ba38f29fdb727fa804 100644
> --- a/drivers/i2c/geni_i2c.c
> +++ b/drivers/i2c/geni_i2c.c
> @@ -330,17 +330,15 @@ static int geni_i2c_disable_clocks(struct udevice *dev, struct geni_i2c_priv *ge
>   
>   	if (geni->is_master_hub) {
>   		ret = clk_disable(&geni->core);
>   		if (ret) {
> -			dev_err(dev, "clk_enable core failed %d\n", ret);
> -			return ret;
> +			dev_err(dev, "clk_disable core failed %d\n", ret);

Hmm.. why do you remove the return?

>   		}
>   	}
>   
>   	ret = clk_disable(&geni->se);
>   	if (ret) {
> -		dev_err(dev, "clk_enable se failed %d\n", ret);
> -		return ret;
> +		dev_err(dev, "clk_disable se failed %d\n", ret);
>   	}
>   
>   	return 0;
>   }
> 

In case of error, you return now 0 ?

If you intentionally want this change, please describe this in
your commit message and why you want this...

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de