Aw: [U-Boot, v1, 1/1] net: phy: Add the Airoha EN8811H PHY driver

[Lucien.Jheng]

Frank Wunderlich 於 2025/6/12 下午 10:44 寫道:
> Am 12. Juni 2025 16:36:41 MESZ schrieb Tom Rini<trini at konsulko.com>:
>> On Thu, Jun 12, 2025 at 10:09:48AM +0000,frank-w at public-files.de wrote:
>>
>>>> Gesendet: Sonntag, 11. Mai 2025 um 07:14
>>>> Von: "Lucien.Jheng"<lucienzx159 at gmail.com>
>>>> Betreff: [U-Boot, v1, 1/1] net: phy: Add the Airoha EN8811H PHY driver
>>>>
>>>> Add the driver for the Airoha EN8811H 2.5 Gigabit PHY. The PHY supports
>>>> 100/1000/2500 Mbps with auto negotiation only.
>>>>
>>>> The driver uses two firmware files, for which updated versions are added to
>>>> linux-firmware already.
>>>>
>>>> Locating the AIROHA FW within the filesystem at the designated partition
>>>> and path will trigger its automatic loading and writing to the PHY via MDIO.
>>>> If need board specific loading override,
>>>> please override the en8811h_read_fw function on board or architecture level.
>>>>
>>>> Linux upstream AIROHA EN8811H driver commit:
>>>> 71e79430117d56c409c5ea485a263bc0d8083390
>>>>
>>>> Based on the Linux upstream AIROHA EN8811H driver code(air_en8811h.c),
>>>> I have modified the relevant process to align with the U-Boot boot sequence.
>>>> and have validated this on Banana Pi BPI-R3 Mini.
>>>>
>>>> Signed-off-by: Lucien.Jheng<lucienzx159 at gmail.com>
>>>> ---
>>>>   drivers/net/phy/Kconfig       |  43 ++
>>>>   drivers/net/phy/air_en8811h.c | 852 ++++++++++++++++++++++++++++++++++
>>>>   2 files changed, 895 insertions(+)
>>>>   create mode 100644 drivers/net/phy/air_en8811h.c
>>> Hi,
>>>
>>> is there any progress? i see no review or apply (+tom in To-header).
>> I'm not super thrilled at the concept of having to load firmware from a
>> filesystem. But since we have to do this anyways in other cases, is this
>> something we could be using FS_LOADER for or no?
>>
> The filesystem loading was requested in mailinglist.
> Original version loaded firmware from emmc boot1 partition (current openwrt driver version) or c header file generated from the binaries (my version). I do not know FS_LOADER yet,but if this a more generic way to load firmware file it could be a way. Lucien,what do you think?
>
>
> regards Frank

I'm not very familiar with the FS_LOADER part of U-Boot, so I'll need to look into that.

However, based on previous mailing list discussions, it was suggested that I refer to the Aquatia PHY and its method of loading the PHY firmware from the filesystem on a block device.

Additionally, the recommendation was to implement a __weak default loading from a file on the filesystem by default.

This way, if a specific platform needs to replace its loading method, it can simply be overridden at the board or architecture level.

Thanks
Lucien Jheng