[PATCH RFC v2 4/8] binman: replace _entries with GetEntries()

[Yannic Moog]

Am Freitag, dem 30.05.2025 um 12:18 +0100 schrieb Simon Glass:
> Hi Yannic,
> 
> On Tue, 27 May 2025 at 14:24, Yannic Moog <y.moog at phytec.de> wrote:
> > 
> > _entries, as highlighted by leading _, is a private member and thus
> > should not be accessed directly. As a result use the GetEntries function
> > instead.
> > GetEntries() returns _entries. No functional change introduced in this
> > commit.
> > 
> > Signed-off-by: Yannic Moog <y.moog at phytec.de>
> > ---
> >  tools/binman/etype/atf_fip.py         |  4 ++--
> >  tools/binman/etype/blob_phase.py      |  4 ++--
> >  tools/binman/etype/cbfs.py            | 12 +++++-----
> >  tools/binman/etype/efi_capsule.py     |  2 +-
> >  tools/binman/etype/fit.py             |  4 ++--
> >  tools/binman/etype/mkimage.py         |  4 ++--
> >  tools/binman/etype/nxp_imx8mcst.py    |  2 +-
> >  tools/binman/etype/nxp_imx8mimage.py  |  2 +-
> >  tools/binman/etype/section.py         | 44 +++++++++++++++++---------------
> > ---
> >  tools/binman/etype/ti_board_config.py |  8 +++----
> >  tools/binman/ftest.py                 |  2 +-
> >  11 files changed, 44 insertions(+), 44 deletions(-)
> 
> Are you sure this is right? The classes which use _entries are
> subclasses, except for ftest.py which is test code where we should
> probably add:
> 
> #pylint: disable=protected-access

I don't think this is right on second thought. I'll drop this patch altogether
as I would like to focus on (imo) more important aspects of the series first.


> 
> Regards,
> Simon