[PATCH] usb: gadget: atmel: reliably generate disconnect by disabling controller instead of toggling PULLD_DIS

[Zixun LI]

On Mon, Jun 16, 2025 at 9:28 AM Mattijs Korpershoek
<mkorpershoek at kernel.org> wrote:
>
> On Mon, Jun 16, 2025 at 09:24, Mattijs Korpershoek <mkorpershoek at kernel.org> wrote:
>
> > On Fri, Jun 13, 2025 at 16:45, Zixun LI <admin at hifiphile.com> wrote:
> >
> >> On Fri, Jun 13, 2025 at 11:22 AM Mattijs Korpershoek
> >>
> >> Hi Mattijs,
> >>
> >> The case was reported in early May and MCHP have also observed the
> >> missing of detach event on host.
> >>
> >> My latest measure shows a differential signal level about +-350mV
> >> between DP&DM lines when
> >> DETACH and PULLD_DIS bits are 1, much lower than the detachment
> >> threshold of 625mV from
> >> USB 2.0 specification Table 7.3.
> >>
> >> From my view the patch can be picked, even on an unaffected family it
> >> won't have side effects.
> >> Unless one day we decide to implement SAM9RL and SAM9G45 errata then
> >> it needs to be retested.
> >
> > Ok, I will apply it. Since it's a bit late in the release cycle, I'll
> > send this out for -next.
>
> Zixun, before applying the patch, I'd like to add the comment I
> suggested in the code [1] as well.
>
> Do you you have any objections on that?
> PLease let me know
>
> [1] https://lore.kernel.org/all/87iklbuddu.fsf@kernel.org/
>
> >
> > Thanks again for your contribution!
> >
> > Mattijs
> >
> >>
> >> Best Regards,
> >> Zixun

Hi Mattijs,

I agree to add the comment to make it more clear.

Best regards,
Zixun