[PATCH] Improve user feedback in case of FPGA bitstream load failure

[Tom Rini]

On Wed, Jun 18, 2025 at 05:44:29PM +0200, Pieter Van Trappen wrote:
> On 18/06/2025 15:57, Tom Rini wrote:
> > On Wed, Jun 18, 2025 at 09:15:54AM +0200, Michal Simek wrote:
> > > 
> > > 
> > > On 6/17/25 11:23, vtpieter at gmail.com wrote:
> > > > From: Pieter Van Trappen <pieter.van.trappen at cern.ch>
> > > > 
> > > > In fpga.c, change debug() calls to puts() for important user
> > > > feedback. In zynqpl.c, change 'up to' to 'above' which corrects this
> > > > confusing or wrong statement.
> > > > 
> > > > Signed-off-by: Pieter Van Trappen <pieter.van.trappen at cern.ch>
> > > > ---
> > > >    cmd/fpga.c            | 20 ++++++++++----------
> > > >    drivers/fpga/zynqpl.c |  2 +-
> > > >    2 files changed, 11 insertions(+), 11 deletions(-)
> > > > 
> > > > diff --git a/cmd/fpga.c b/cmd/fpga.c
> > > > index 9dc7b63db5d..2c2a63524de 100644
> > > > --- a/cmd/fpga.c
> > > > +++ b/cmd/fpga.c
> > > > @@ -43,7 +43,7 @@ static int do_fpga_check_params(long *dev, long *fpga_data, size_t *data_size,
> > > >    	debug("%s %d, %d\n", __func__, argc, cmdtp->maxargs);
> > > >    	if (argc != cmdtp->maxargs) {
> > > > -		debug("fpga: incorrect parameters passed\n");
> > > > +		puts("fpga: incorrect parameters passed\n");
> > > 
> > > I think all of these should be moved to log_err that you should be able to
> > > control verbosity.
> > > 
> > > Tom: I think this is where you want to go right?
> > 
> > Sounds right, thanks.
> > 
> 
> Right I will amend accordingly in a v2.
> 
> I'm trying to compile now that it's more than some tweaks and I notice many
> (fixable) errors in the drivers/fpga files such as missing time.h includes,
> spotted by gcc 14.2 (x86_64). I'm on the next branch.
> 
> Is this due to my gcc being too recent or is something else going on? I
> don't mind patching these in case that's welcomed; let me know.

Just further changes on the next branch which your changes are exposing
I guess, separate patches for them would be much appreciated, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20250618/c7d74a15/attachment.sig>