SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION_TYPE broken since commit 2a00d73

[Quentin Schulz]

Hi Thomas,

On 6/25/25 2:44 PM, Thomas Lorblanchès wrote:
> [You don't often get email from zlika_ese at hotmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Hi all,
> There is a problem with commit 2a00d73 (spl: mmc: Try to clean up raw-mode options):
> now options SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION and SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION_TYPE are mutually exclusive.
> However, SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION_TYPE is only used in common/spl/spl_mmc.c inside
> a "#define SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION" block.
> So this 
commit breaks the option SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION_TYPE.

Seems like you're right indeed.

I think we also have an issue with dead code in 
mmc_load_image_raw_partition() function where we have ifdefery around 
CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR which cannot be set since 
it's another choice Kconfig in common with other 
SYS_MMCSD_RAW_MODE_U_BOOT_USE_* options.

To be honest, I'm not sure how to fix this appropriately. I'm also not 
sure the

#ifdef SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION

addition in arch/arm/mach-imx/imx8m/soc.c of the aforementioned commit 
is proper as it surrounds something that allows to get a sector, which 
isn't something you should be needing when using U_BOOT_USE_PARTITION?

I won't be available until 3rd week of July so cannot dig into that 
myself unfortunately. Would be nice if someone else (you?) could dig a 
bit and maybe even come up with a fix?

Cheers,
Quentin